Activity leahi-dialin/leahi_dialin/common/msg

9:37 am

Sean Nash

More
LEAHI-DIALIN-LDT-3433-1
left review

10:23 am

Dara Navaei

More
LEAHI-DIALIN-LDT-3433-1
started review

LEAHI-DIALIN-LDT-3433_Water, Dialysate, and Blood Sampling - SW - 01 - Water sample & Dialysate Checks - R&I

11:33 am

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-3287-1
finished reviewing

9:10 am

Michael Garthwaite

reverted handler to the original version. This was required to get a merge with develop to work

9:09 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3287-1
commented on review

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete. Please re...

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

3:34 pm

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3287-1
commented on review

Duplicate, please remove

1:33 pm

Vendor - TEL - Sameer Poyil , Sean Nash and Zoltan Miskolci

More
LEAHI-DIALIN-LDT-2004-1
finished reviewing

11:23 am

Vendor - TEL - Sameer Poyil

merged staging into dry bicart branch and code is pushed

11:22 am

Vendor - TEL - Sameer Poyil

New code pushed

9:29 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-2004-1
commented on review

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place Broadcast -> cmd_generic_broadcast_interval_override others -> cmd_generic_ov...

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

9:26 am

Zoltan Miskolci

This is not the code that is currently on staging, so I think you need to update it from there

8:57 pm

Vendor - TEL - Sameer Poyil

fixed it

5:55 pm

Vendor - TEL - Sameer Poyil

This is a change from Zoltan and I am updated that into my local branch

4:20 pm

Sean Nash

More
LEAHI-DIALIN-LDT-3287-1
resumed reviewing

10:34 am

Zoltan Miskolci

4:46 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-3350-1
finished reviewing

8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm