RinsePump.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I'm not seeing fixes in this file.

I'm not seeing fixes in this file.

Remove extra blank line.

Remove extra blank line.

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

moved the sets into a separate function from init

moved the sets into a separate function from init

Done

Done

comments should start with capital letter

comments should start with capital letter

Move up with other controllers.

Move up with other controllers.

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states? I would recommend we combine these 3 ...

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states?

I would recommend we combine these 3 fpga functions into one single function that takes all 3 params and updates all 3 registers.

I think these should be initialized to zero in case there are unused bits that won't be set below.

I think these should be initialized to zero in case there are unused bits that won't be set below.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

Align comments in all of this switch cases

Align comments in all of this switch cases

Done.

Done.