LEAHI-DD-FIRMWARE-LDT-3238-1 LEAHI-DD-FIRMWARE-LDT-3238_Update unit names for submodes to have a prefix "state"

closed on 16 Jan

Author

Moderator

Reviewers

LEAHI-DD-FIRMWARE-LDT-3238_Update unit names for submodes to have a prefix...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 24

dd-firmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Modes/FPModes 0
      - File FlushConcentrate.c 0 Remove
      - File FlushConcentrate.h 0 Remove
      - File FlushFilter.c 0 Remove
      - File FlushFilter.h 0 Remove
      - File FlushFilterDefeatured.c 0 Remove
      - File FlushFilterDefeatured.h 0 Remove
      - File FlushPermeate.c 0 Remove
      - File FlushPermeate.h 0 Remove
      - File InletPressureCheck.c 0 Remove
      - File InletPressureCheck.h 0 Remove
      - File ModePreGenPermeate.c 0 Remove
      - File ModePreGenPermeateDefeatured.c 0 Remove
      - File StateFlushConcentrate.c 0 Remove
      - File StateFlushConcentrate.h 0 Remove
      - File StateFlushFilter.c 0 Remove
      - File StateFlushFilter.h 0 Remove
      - File StateFlushFilterDefeatured.c 0 Remove
      - File StateFlushFilterDefeatured.h 0 Remove
      - File StateFlushPermeate.c 0 Remove
      - File StateFlushPermeate.h 0 Remove
      - File StateInletPressureCheck.c 0 Remove
      - File StateInletPressureCheck.h 0 Remove
    - Folder Services 0
      - File Messaging.c 0 Remove
  - Folder source 0
    - File sys_main.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Raghu Kallala	Author & Moderator	2m
Vendor - TEL - Sameer Poyil	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - Complete	1m
Vendor - TEL - Arpita Srivastava	Reviewer - 0% reviewed
Vendor - TEL - Varshini Nagabooshanam	Reviewer - 0% reviewed
Daniel Ho	Reviewer - 0% reviewed
Sean Nash	Reviewer - Complete	5m
Vendor - TEL - Jashwant Gantyada	Reviewer - 0% reviewed	0m
Dara Navaei	Reviewer - Complete	1m
Total		10m	0

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/firmware/App/.../FPModes/FlushConcentrate.c Deleted

Click to load diff

/firmware/App/.../FPModes/FlushConcentrate.h Deleted

Click to load diff

/firmware/App/Modes/FPModes/FlushFilter.c Deleted

Click to load diff

/firmware/App/Modes/FPModes/FlushFilter.h Deleted

Click to load diff

/firmware/.../FPModes/FlushFilterDefeatured.c Deleted

Click to load diff

/firmware/.../FPModes/FlushFilterDefeatured.h Deleted

Click to load diff

/firmware/App/.../FPModes/FlushPermeate.c Deleted

Click to load diff

/firmware/App/.../FPModes/FlushPermeate.h Deleted

Click to load diff

/firmware/App/.../FPModes/InletPressureCheck.c Deleted

Click to load diff

/firmware/App/.../FPModes/InletPressureCheck.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DD-FIRMWARE-LDT-3238-1

LEAHI-DD-FIRMWARE-LDT-3238_Update unit names for submodes to have a prefix...

LEAHI-DD-FIRMWARE-LDT-3238-1 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-DD-FIRMWARE-LDT-3238_Update unit names for submodes to have a prefix...

LEAHI-DD-FIRMWARE-LDT-3238-1 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time