•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-5613-1 21 Aug 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

added

LEAHI-TD-FIRMWARE-LDT-4149-1 17 Aug 2026

Sorry, fixed

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

Why add tx end state here?

LEAHI-TD-FIRMWARE-LDT-5613-1 21 Aug 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-5186-1 14 Aug 2026

updated

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Added

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Agree!

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

Should it be H1?

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

add @param

LEAHI-TD-FIRMWARE-LDT-4149-1 13 Aug 2026

fix indentation

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Added

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

fixed

LEAHI-TD-FIRMWARE-LDT-4149-1 17 Aug 2026

Remove status from inputs.

LEAHI-TD-FIRMWARE-LDT-4049-1 18 Aug 2026

This isn't right. Look at staging for correct code.

LEAHI-TD-FIRMWARE-LDT-2240-1 12 Jun 2026

Are these being initialized in the init function?

LEAHI-TD-FIRMWARE-LDT-2240-1 19 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

Add doxygen comment to right.

LEAHI-TD-FIRMWARE-LDT-4050-1 20 Aug 2026

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes?
You have an enum of heat disinfection commands, so why do we need separate messages for each disinfection? Should just be 1 message to start a disinfection with a command enum as its payload.

LEAHI-TD-FIRMWARE-LDT-5613-1 21 Aug 2026

Remove blank line.

LEAHI-DIALIN-LDT-5186-1 14 Aug 2026

indent

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

added

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Added

LEAHI-DD-FIRMWARE-LDT-5409-1 18 Aug 2026

Add doxygen comments to right.

LEAHI-DD-FIRMWARE-LDT-4024-1 19 Aug 2026

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

Fix indents and align with others.

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

What is this function doing in Dialysis unit? And who is calling it? It's public, but I don't see that you added it to header file so nobody can call it anyway.

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

Add blank line between includes and group header.

LEAHI-APPLICATION-LDT-5600-1 20 Aug 2026

updated

LEAHI-TD-FIRMWARE-LDT-4050-1 14 Aug 2026

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

LEAHI-TD-FIRMWARE-LDT-4050-1 14 Aug 2026

Initialize this.

LEAHI-TD-FIRMWARE-LDT-4050-1 20 Aug 2026

Shouldn't auto-eject state handle this BP homing?

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-5363-1 17 Aug 2026

I think != TRUE is better in these cases.

LEAHI-TD-FIRMWARE-LDT-2240-1 19 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4050-1 14 Aug 2026

Just move msg handlers from Messaging to here so you don't need a signal.

LEAHI-DIALIN-LDT-5409-1 19 Aug 2026

Keep the original format, string input is not supported by the processor

LEAHI-TD-FIRMWARE-LDT-2240-1 19 Aug 2026

TaskGeneral is included twice. Remove this one.

LEAHI-DD-FIRMWARE-LDT-4049-1 19 Aug 2026

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

LEAHI-TD-FIRMWARE-LDT-4050-1 14 Aug 2026

Not needed? Add another BOOL for disinfection option received.

LEAHI-TD-FIRMWARE-LDT-4149-1 14 Aug 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-5363-1 18 Aug 2026

Add initialBloodFlowComplete and preTxRecircStartTime to inputs.

LEAHI-APPLICATION-LDT-5158-1 18 Aug 2026

remove the ok and just check result and if any fails goto invalid

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

Add blank line before return.

LEAHI-TD-FIRMWARE-LDT-4036-1 20 Aug 2026

Add blank line between declarations and code.

LEAHI-APPLICATION-LDT-5158-1 20 Aug 2026

bn approves

LEAHI-TD-FIRMWARE-LDT-4050-1 20 Aug 2026

Why is this above the definitions banner?

LEAHI-TD-FIRMWARE-LDT-4050-1 14 Aug 2026

Remove disable of ejector motor.

LEAHI-TD-FIRMWARE-LDT-4050-1 20 Aug 2026

Shouldn't this be UI REQUEST message? Why would we need to receive/handle a message that we send?