LEAHI-DD-FIRMWARE-LDT-3978

LEAHI-DD-FIRMWARE-LDT-3978

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 5
Total Commits: 3,385
Last Commit: 05 Jun
Commits this week: 5

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Sunday 10 May
11:30 pm

Vendor - TEL - Sameer Poyil

11:28 pm

Vendor - TEL - Sameer Poyil

Tuesday 05 May
12:32 pm

Vendor - TEL - Varshini Nagabooshanam , Vendor - TEL - Arpita Srivastava and Raghu Kallala

12:32 pm

Raghu Kallala , Vendor - TEL - Arpita Srivastava and Vendor - TEL - Varshini Nagabooshanam

11:10 am

Vendor - TEL - Arpita Srivastava and Raghu Kallala

11:10 am

Raghu Kallala and Vendor - TEL - Arpita Srivastava

Friday 01 May
10:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
4:03 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
Thursday 30 Apr
2:23 pm

Vendor - TEL - Sameer Poyil

1:42 pm

Sean Nash

10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Tuesday 28 Apr
11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Monday 27 Apr
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Sunday 26 Apr
12:36 pm

Sean Nash

Declare local variables at top of scope.

Declare local variables at top of scope.

12:34 pm

Sean Nash

Add space between ( and ?

Add space between ( and ?

12:33 pm

Sean Nash

Remove blank line.

Remove blank line.

12:31 pm

Sean Nash

Why redeclare result?

Why redeclare result?

12:31 pm

Sean Nash

Remove blank line.

Remove blank line.

12:30 pm

Sean Nash

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

12:30 pm

Sean Nash

Remove blank line.

Remove blank line.

12:29 pm

Sean Nash

Remove blank line.

Remove blank line.

Friday 24 Apr
10:17 pm

Vinayakam Mani

Thursday 23 Apr
2:59 pm

Vinayakam Mani