Zoltan Miskolci

updated

updated

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

Fix Spacing please to be consistent with the rest of the variables

Fix Spacing please to be consistent with the rest of the variables

Please maintain the FW-SW Integration.xlsx for MSG_ID reservation. Meaning, add these there too to avoid overwriting or deleting them

Please maintain the FW-SW Integration.xlsx for MSG_ID reservation.
Meaning, add these there too to avoid overwriting or deleting them

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

dd_enum_repository -> fp_enum_repository

dd_enum_repository -> fp_enum_repository

Put this into a dataclass folder under common, so we start structuring it.

Put this into a dataclass folder under common, so we start structuring it.

Not in use, don't need to add

Not in use, don't need to add

2 empty lines please

2 empty lines please

2 lines between functions please

2 lines between functions please

remove empty line

remove empty line

remove 3rd empty line

remove 3rd empty line

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Rename to CanChannels

Fix it, it's CanChannels, not DenaliChannels

Fix it, it's CanChannels, not DenaliChannels

2 blank lines, to keep structure, thank you

2 blank lines, to keep structure, thank you

Please update the location to fp_enum_repository as P9 is an FP sensor.

Please update the location to fp_enum_repository as P9 is an FP sensor.

Add type definition for can_interface.

Add type definition for can_interface.