Zoltan Miskolci

About
  • First commit 03 December 2025
  • Latest commit 03 February 2026
Last Week All Time
Commits: 19 125

Reviews

22 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Zoltan Miskolci is mapped to 3 committers over 2 repositories
Username zmiskolci is mapped to:
Today
4 hrs ago

Zoltan Miskolci

5 hrs ago

Zoltan Miskolci

5 hrs ago

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

5 hrs ago

Zoltan Miskolci

removed commented out line

removed commented out line

5 hrs ago

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

5 hrs ago

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

5 hrs ago

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

5 hrs ago

Zoltan Miskolci

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

5 hrs ago

Zoltan Miskolci

Yes

Yes

5 hrs ago

Zoltan Miskolci

Based on the msg id, it should be here

Based on the msg id, it should be here

10 hrs ago

Zoltan Miskolci

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

Friday 30 Jan
4:55 pm

Zoltan Miskolci

Removed

Removed

11:30 am

Zoltan Miskolci

Wednesday 28 Jan
9:09 am

Zoltan Miskolci

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the in...

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the init process and to not have confusing messages

Tuesday 27 Jan
1:32 pm

Zoltan Miskolci

merged

merged

1:32 pm

Zoltan Miskolci

renamed

renamed

1:32 pm

Zoltan Miskolci

renamed

renamed

1:32 pm

Zoltan Miskolci

Updated based on FW

Updated based on FW

11:40 am

Zoltan Miskolci

updated

updated

11:40 am

Zoltan Miskolci

updated, thanks for the confirmation

updated, thanks for the confirmation

11:34 am

Zoltan Miskolci

renamed

renamed

11:33 am

Zoltan Miskolci

9:24 am

Zoltan Miskolci

Monday 26 Jan
4:51 pm

Zoltan Miskolci

3:13 pm

Zoltan Miskolci

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue. you are sending a message with this msg id and this p...

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

12:26 pm

Zoltan Miskolci

Can't we use the generic override? You just need to update 3 fields: msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST entity_name = 'DD Coductivity sensor model request' override_text = 'S...

Can't we use the generic override?
You just need to update 3 fields:

msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
entity_name = 'DD Coductivity sensor model request'
override_text = 'Sent' or ''

Thursday 22 Jan
10:07 am

Zoltan Miskolci

Wednesday 21 Jan
12:39 pm

Zoltan Miskolci

12:22 pm

Zoltan Miskolci

11:08 am

Zoltan Miskolci