application

sources

Clone Tools

Stats

Commits this week: 1
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Nov 2020
5:05 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Reverting adding a left and right touch margin

- While the addition of these margins makes it easier to hit the knob, it also adds a distance during drag between the click point and the displayed knob position. If still needed, there should be a better way of increasing the left and right touch margin.

Options
    • -2
    • +0
    ./gui/qml/components/RangeRect.qml
4:13 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Updated ConfirmTreatmentTableEntry's description

Options
    • -0
    • +1
    ./gui/qml/components/ConfirmTreatmentTableEntry.qml
4:01 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Moved ConfirmTreatmentTableEntry.qml to the right place.

Options
    • -0
    • +66
    ./gui/qml/components/ConfirmTreatmentTableEntry.qml
  2. … 2 more files in changeset.
3:47 pm

Peter Lucia <plucia@diality.com>

DEN-4609: Addressed code review comments, misc. cleanup

Options
    • -4
    • +1
    ./gui/qml/components/ConfirmTreatmentSubTable.qml
    • -7
    • +47
    ./gui/qml/components/TopMenuBarCreateTreatment.qml
    • -2
    • +2
    ./view/VTreatmentBegin.h
  4. … 3 more files in changeset.
3:09 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -0
    • +31
    ./model/dg/data/MDGAccelerometerData.h
    • -0
    • +32
    ./model/hd/data/MHDAccelerometerData.h
    • -8
    • +38
    ./model/hd/data/MHDVersionData.h
1:22 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -12
    • +11
    ./model/hd/data/MHDVersionData.h
    • -0
    • +7
    ./view/dg/data/VDGAccelerometerData.h
    • -0
    • +7
    ./view/hd/data/VHDAccelerometerData.h
12:17 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607: Updated unit tests, removed unused Storage namespace from ApplicationController.cpp, removed saveNewTreatment function from ApplicationController.h

Options
    • -1
    • +0
    ./ApplicationController.cpp
    • -2
    • +0
    ./ApplicationController.h
    • -7
    • +8
    ./view/VTreatmentCreate.cpp
  4. … 2 more files in changeset.
11:56 am

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Addressed code review comments.

Options
    • -0
    • +1
    ./gui/guiglobals.h
    • -2
    • +2
    ./model/hd/data/MHDAccelerometerData.h
    • -0
    • +74
    ./model/hd/data/MHDVersionData.h
  4. … 1 more file in changeset.
Sunday 01 Nov 2020
11:45 pm

Behrouz NematiPour

DEN-4695: Integration Testing

- Fixed broken names in SquishQt

Options
    • -2
    • +2
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentStart.qml
    • -124
    • +0
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentPressures.qml
    • -0
    • +124
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
    • -0
    • +104
    ./gui/qml/pages/treatment/sections/TreatmentPressures.qml
    • -104
    • +0
    ./gui/qml/pages/treatment/sections/TreatmentPressuresLimits.qml
    • -2
    • +2
    ./model/hd/adjustment/MTreatmentAdjustRequests.h
  8. … 2 more files in changeset.
8:21 pm

Behrouz NematiPour

Removed extra empty lines

Options
    • -1
    • +0
    ./ApplicationController.cpp
    • -1
    • +0
    ./canbus/CanInterface.h
    • -1
    • +0
    ./canbus/FrameInterface.cpp
    • -1
    • +0
    ./canbus/MessageAcknowModel.cpp
    • -1
    • +0
    ./canbus/MessageInterpreter.cpp
    • -1
    • +0
    ./canbus/MessageInterpreter.h
    • -1
    • +0
    ./gui/qml/globals/Colors.qml
    • -2
    • +0
    ./gui/qml/globals/Variables.qml
    • -2
    • +0
    ./gui/qml/pages/SettingsHome.qml
    • -1
    • +0
    ./gui/qml/pages/treatment/TreatmentBegin.qml
    • -1
    • +0
    ./gui/qml/pages/treatment/TreatmentConfirm.qml
    • -3
    • +0
    ./gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +0
    ./gui/qml/pages/treatment/TreatmentPrime.qml
    • -1
    • +0
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +0
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml
  16. … 23 more files in changeset.
8:18 pm

Behrouz NematiPour

DEN-5033: DEN-5034: Implementation [ Messaging ]

- Back end implementation of the messaging.

Options
    • -0
    • +15
    ./canbus/MessageDispatcher.cpp
    • -0
    • +1
    ./canbus/MessageDispatcher.h
    • -0
    • +4
    ./canbus/MessageGlobals.h
    • -0
    • +7
    ./canbus/MessageInterpreter.cpp
    • -0
    • +1
    ./gui/GuiGlobals.cpp
    • -48
    • +50
    ./gui/GuiGlobals.h
    • -5
    • +5
    ./gui/qml/pages/Diagnostics.qml
    • -5
    • +5
    ./gui/qml/pages/ManagerHome.qml
    • -2
    • +4
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentStart.qml
    • -104
    • +0
    ./gui/qml/pages/treatment/sections/TreatmentPressure.qml
    • -0
    • +104
    ./gui/qml/pages/treatment/sections/TreatmentPressuresLimits.qml
    • -5
    • +14
    ./model/MModel.h
    • -0
    • +61
    ./model/hd/adjustment/MTreatmentAdjustPressuresLimitsResponse.cpp
    • -0
    • +96
    ./model/hd/adjustment/MTreatmentAdjustPressuresLimitsResponse.h
  16. … 10 more files in changeset.
5:46 pm

Behrouz NematiPour

Merge branch 'master' into DEN-4691_InLineBloodPressureAdjustments

Options
    • -8
    • +11
    ./ApplicationController.cpp
    • -8
    • +4
    ./ApplicationController.h
    • -2
    • +2
    ./gui/qml/components/RangeBar.qml
    • -2
    • +6
    ./gui/qml/components/RangeRect.qml
    • -2
    • +2
    ./gui/qml/components/TickMarks.qml
    • -39
    • +48
    ./gui/qml/globals/Colors.qml
    • -1
    • +2
    ./gui/qml/globals/Fonts.qml
    • -8
    • +18
    ./gui/qml/globals/Variables.qml
    • -26
    • +64
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -3
    • +3
    ./gui/qml/pages/treatment/sections/TreatmentPressure.qml
    • -8
    • +11
    ./storage/FileHandler.h
    • -8
    • +11
    ./view/VEventSpy.cpp
  13. … 2 more files in changeset.
Friday 30 Oct 2020
7:49 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607: Added VTreatmentEnd.cpp/.h, Added end treatment button to settings page, misc. cleanup.

Options
    • -19
    • +0
    ./VTreatmentBegin.cpp
    • -35
    • +0
    ./VTreatmentBegin.h
    • -0
    • +1
    ./canbus/MessageGlobals.h
    • -0
    • +1
    ./gui/GuiGlobals.cpp
    • -2
    • +2
    ./gui/GuiGlobals.h
    • -0
    • +2
    ./gui/qml/main.qml
    • -0
    • +17
    ./gui/qml/pages/SettingsHome.qml
    • -2
    • +2
    ./model/MEndTreatmentResponse.h
    • -0
    • +15
    ./view/VTreatmentBegin.cpp
    • -0
    • +37
    ./view/VTreatmentBegin.h
    • -0
    • +40
    ./view/VTreatmentEnd.cpp
    • -0
    • +40
    ./view/VTreatmentEnd.h
    • -0
    • +1
    ./view/VView.h
    • -20
    • +0
    ./view/hd/alarm/VAlarmStatus.cpp
    • -2
    • +0
    ./view/hd/alarm/VAlarmStatus.h
  16. … 2 more files in changeset.
1:41 pm

Peter Lucia <plucia@diality.com>

DEN-4598, DEN-4609, DEN-4607, DEN-4605: Updated unit tests and code coverage. Made changes requested in code review.

Options
    • -0
    • +6
    ./VTreatmentBegin.h
    • -0
    • +2
    ./canbus/MessageInterpreter.h
    • -1
    • +1
    ./gui/GuiGlobals.h
    • -0
    • +1
    ./gui/qml/components/TopMenuBarCreateTreatment.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentBegin.qml
    • -0
    • +55
    ./storage/FileSaver.cpp
    • -0
    • +50
    ./storage/FileSaver.h
    • -55
    • +0
    ./storage/filesaver.cpp
    • -50
    • +0
    ./storage/filesaver.h
    • -0
    • +6
    ./view/VPriming.h
    • -0
    • +2
    ./view/VTreatmentCreate.cpp
    • -4
    • +4
    ./view/VTreatmentCreate.h
    • -0
    • +20
    ./view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +9
    ./view/hd/alarm/VAlarmStatus.h
  15. … 8 more files in changeset.
Wednesday 28 Oct 2020
3:01 pm

Behrouz NematiPour

DEN-5341: Code Analysis

- Found an unused code and removed.

Options
    • -4
    • +1
    ./ApplicationController.h
9:11 am

Peter Lucia <plucia@diality.com>

DEN-5520: Updated mSignalStrengthPct comment to match the variable.

Options
    • -8
    • +8
    ./model/hd/data/MTreatmentFlowsData.h
Tuesday 27 Oct 2020
10:51 pm

Behrouz NematiPour

DEN-5341: Code Analysis

- some dox updated as well.

Options
    • -0
    • +1
    ./model/hd/adjustment/MTreatmentAdjustSalineResponse.h
    • -2
    • +2
    ./model/hd/data/MTreatmentStatesData.h
  3. … 1 more file in changeset.
9:21 pm

Behrouz NematiPour

DEN-5340 Code Coverage [100%]

- Coverage to 100%

- Added "Profile" build setup for Code Coverage Instrumentation and build in the workspace_UI with the output name of denaliSquish

- Modified the Pressure/Occlusion message to have new structure (last 3 of 5 fields changed to U32 from F32)

Options
    • -3
    • +3
    ./gui/qml/pages/ManagerHome.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/sections/TreatmentPressure.qml
    • -9
    • +9
    ./model/hd/data/MTreatmentPressureOcclusionData.h
    • -2
    • +4
    ./view/hd/adjustment/VTreatmentAdjustmentSaline.cpp
    • -5
    • +5
    ./view/hd/data/VTreatmentPressureOcclusion.h
  6. … 1 more file in changeset.
1:45 pm

Behrouz NematiPour

DEN-5340 Code Coverage [99.953%]

- Covered the sbOff/sbIdle

Options
    • -2
    • +6
    ./gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -2
    • +2
    ./view/hd/data/VHDTreatmentStatesData.cpp
    • -1
    • +1
    ./view/hd/data/VHDTreatmentStatesData.h
12:44 pm

Behrouz NematiPour

DEN-5340 Code Coverage [99.881%]

- removed unused codes.

- commented unused codes.

Options
    • -25
    • +0
    ./canbus/MessageInterpreter.cpp
    • -1
    • +0
    ./canbus/MessageInterpreter.h
    • -1
    • +3
    ./view/hd/adjustment/VTreatmentAdjustmentSaline.cpp
    • -0
    • +7
    ./view/hd/adjustment/VTreatmentAdjustmentSaline.h
    • -0
    • +6
    ./view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationState.h
    • -9
    • +25
    ./view/hd/data/VHDTreatmentStatesData.h
  7. … 3 more files in changeset.
11:18 am

Peter Lucia <plucia@diality.com>

DEN-4605: Updated unit tests

Options
    • -4
    • +0
    ./canbus/MessageInterpreter.h
    • -0
    • +2
    ./model/hd/data/MPrimingData.h
  3. … 4 more files in changeset.
Monday 26 Oct 2020
5:21 am

Behrouz NematiPour

DEN-5339: Integration Testing

- Debugging, Refactoring, Testing

Options
    • -6
    • +7
    ./canbus/MessageDispatcher.h
    • -0
    • +1
    ./canbus/MessageGlobals.h
    • -18
    • +13
    ./canbus/MessageInterpreter.cpp
    • -1
    • +3
    ./gui/GuiGlobals.h
    • -3
    • +1
    ./gui/qml/components/ModalDialog.qml
    • -8
    • +8
    ./gui/qml/components/NotificationBar.qml
    • -1
    • +0
    ./gui/qml/components/NotificationBarSmall.qml
    • -1
    • +2
    ./gui/qml/components/TouchArea.qml
    • -6
    • +0
    ./gui/qml/main.qml
    • -20
    • +24
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +2
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentBase.qml
    • -3
    • +4
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml
    • -3
    • +5
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml
    • -1
    • +2
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml
    • -0
    • +6
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationStart.qml
  16. … 19 more files in changeset.
Friday 23 Oct 2020
10:24 am

Peter Lucia <plucia@diality.com>

DEN-4601, DEN-4607, DEN-5169: Improve Create Treatment page usability, Support latest SquishQt Tests, - Widened Create Treatment Parameters - Removed get and set prefix from the treatment parameter macro

Options
    • -2
    • +3
    ./gui/qml/components/GridSelection.qml
    • -11
    • +11
    ./gui/qml/components/Slider.qml
    • -3
    • +3
    ./gui/qml/components/SliderCreateTreatment.qml
    • -11
    • +7
    ./gui/qml/components/SliderDoubleCreateTreatment.qml
    • -0
    • +2
    ./gui/qml/components/TouchRect.qml
    • -0
    • +1
    ./gui/qml/globals/Colors.qml
    • -0
    • +5
    ./gui/qml/globals/Variables.qml
    • -1
    • +5
    ./gui/qml/pages/treatment/TreatmentBegin.qml
    • -2
    • +2
    ./gui/qml/pages/treatment/TreatmentConfirm.qml
    • -0
    • +3
    ./gui/qml/pages/treatment/TreatmentPrime.qml
    • -4
    • +4
    ./main.h
    • -7
    • +7
    ./view/VTreatmentCreate.cpp
  13. … 1 more file in changeset.
10:24 am

Peter Lucia <plucia@diality.com>

DEN-5169: Removed get and set prefix from the treatment parameter macro.

Options
    • -4
    • +4
    ./main.h
    • -3
    • +3
    ./view/VTreatmentCreate.cpp
10:15 am

Peter Lucia <plucia@diality.com>

DEN-5169: Continue refactoring

Options
    • -4
    • +4
    ./gui/qml/components/ConfirmTreatmentTable.qml
    • -4
    • +3
    ./view/VPriming.h
Thursday 22 Oct 2020
6:25 pm

Peter Lucia <plucia@diality.com>

DEN-5169: Cleanup and refactoring.

Options
    • -2
    • +2
    ./VTreatmentBegin.cpp
    • -3
    • +1
    ./VTreatmentBegin.h
    • -4
    • +4
    ./gui/qml/components/ConfirmTreatmentTable.qml
    • -9
    • +9
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -14
    • +14
    ./main.h
    • -4
    • +6
    ./view/VPriming.cpp
    • -1
    • +1
    ./view/VPriming.h
    • -28
    • +28
    ./view/VTreatmentCreate.cpp
    • -16
    • +16
    ./view/VTreatmentCreate.h
  10. … 2 more files in changeset.
6:13 pm

Behrouz NematiPour

DEN-5337: Implementation

Fixed the issue in the unit test but we had a discussion with FW and we had an agreement:

1 - Adding a third field for the message 65 (What was the accepted requested state, or what state to remain in if requested state is rejected.) which will be used for logging only and the message "15: treatment States" will be used to get the actual states.

2 - After the responses to any messages involving the UF_State, Saline_State, Treatment_State immediately message 15 will be sent to update the UI.

So the next step/commit is to apply this decision.

Options
    • -2
    • +3
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -2
    • +3
    ./view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationState.cpp
    • -0
    • +2
    ./view/hd/data/VHDTreatmentStatesData.cpp
    • -1
    • +1
    ./view/hd/data/VHDTreatmentStatesData.h
  5. … 1 more file in changeset.
9:01 am

Peman Montazemi <pmontazemi@diality.com>

DEN-4964: Formatted file.

Options
    • -32
    • +32
    ./gui/qml/pages/ManagerHome.qml
Wednesday 21 Oct 2020
5:26 pm

Peter Lucia <plucia@diality.com>

Merge master into DEN-4598-Confirm-Priming-Begin

Options
    • -11
    • +5
    ./gui/GuiGlobals.h
    • -3
    • +3
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -2
    • +2
    ./model/MModel.h
    • -1
    • +1
    ./model/hd/adjustment/MTreatmentAdjustRequests.h
    • -1
    • +1
    ./model/hd/alarm/MAlarmStatusData.h
  6. … 2 more files in changeset.
11:05 am

Peter Lucia <plucia@diality.com>

DEN-4601: Priming view improvements

- Replaced priming circle with check with check inside the existing circle

- Increased create treatment scrolling deceleration

- Updated create treatment variable names

Options
    • -15
    • +10
    ./gui/qml/components/ConfirmTreatmentTable.qml
    • -2
    • +1
    ./gui/qml/components/PrimingTimer.qml
    • -0
    • +1
    ./gui/qml/components/SliderCreateTreatment.qml
    • -0
    • +1
    ./gui/qml/components/SliderDoubleCreateTreatment.qml
    • -76
    • +75
    ./gui/qml/globals/Variables.qml
    • -0
    • +1
    ./gui/qml/pages/treatment/TreatmentBegin.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentCreate.qml
    • -7
    • +9
    ./gui/qml/pages/treatment/TreatmentPrime.qml
    • -12
    • +15
    ./view/VPriming.cpp
    • -10
    • +15
    ./view/VPriming.h
  11. … 1 more file in changeset.