Activity dd-firmware/

7:31 pm

Vendor - TEL - Sameer Poyil

More
e197ced
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 46 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 implementing code review comments

- -13
- +10
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -3
- +21
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

3:56 pm

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-2004-3
removed Behrouz NematiPour , Stephen Quong and Tiffany Mejia

3:34 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3222-1
replied to Vendor - TEL - Arpita Srivastava

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

2:22 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

2:17 pm

Sean Nash

So shouldn't we stop trimmer heater here then?

2:08 pm

Vendor - TEL - Arpita Srivastava

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE...

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

1:39 pm

Vendor - TEL - Arpita Srivastava

We can update this function as part of another Jira ticket.

1:21 pm

Sean Nash

This one looks like maybe we could use the helper function. Have Vinay look at it.

1:20 pm

Sean Nash

I don't think so. The state is bit encoded, so special handling is required.

10:52 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

10:51 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Remove extra blank line.

10:01 am

Raghu Kallala

More
3393de3
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 added function to initialize FPGA registers with every setConfig call

- -2
- +56
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -11
- +25
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -0
- +1
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h

9:26 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I don't think we need to check test config for variable initialization.

9:13 am

Vendor - TEL - Sameer Poyil

fixed it

9:10 am

Vendor - TEL - Sameer Poyil

Fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

9:01 am

Vendor - TEL - Sameer Poyil

fixed it

8:58 am

Vendor - TEL - Sameer Poyil

More
f7f6305
changed 6 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 46 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 dry bicart review comment implementation

- -26
- +37
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -103
- +144
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -3
- +0
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -21
- +33
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -10
- +10
/firmware/App/Modes/ModePreGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreGenDialysate.c
- -2
- +5
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c

9:14 pm

chaithra bs <ven.cburudugatta@diality.com>

More
3247c6c
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 16 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : peer review findings addressed for ConcentratePumps file

7:27 pm

Vendor - TEL - Sameer Poyil

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

7:24 pm

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

3:46 pm