Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 46

Total Committers:	16
Last Commit:	21:23
Commits this week:	46

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 09 Feb

9:28 am

Vendor - TEL - Arpita Srivastava

More
17bfea4
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 48 more LEAHI-DD-FIRMWARE-LDT-3222-1

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3222-command-to-override-all-BC

- -2
- +43
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -1
- +11
/firmware/App/Controllers/Valves.h
- History
- Source
- Diff
/firmware/App/Controllers/Valves.h

9:24 am

Michael Garthwaite

More
82264ec
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 44 more LEAHI-DD-FIRMWARE-LDT-3173-1

Merge branch 'staging' into LDT-3173-io-pressure-sensors

- -4
- +46
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c

Sunday 08 Feb

6:59 am

Reddaiah Utti <ven.ureddaiah@diality.com>

More
04ef9dd
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 16 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for RinsePump.c file

6:56 am

Reddaiah Utti <ven.ureddaiah@diality.com>

More
aab4337
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 16 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for BoostPump.c file

Friday 06 Feb

8:02 pm

Vendor - TEL - Sameer Poyil

More
1013708
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 46 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 Restoring the earlier code for execGenDialysateMonitor()

- -21
- +3
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

7:35 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Ya , I forgot the coding guide line . Fixed it

Ya , I forgot the coding guide line .
Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:32 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:31 pm

Vendor - TEL - Sameer Poyil

More
e197ced
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 46 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 implementing code review comments

- -13
- +10
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -3
- +21
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

3:56 pm

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-2004-3
removed Behrouz NematiPour , Stephen Quong and Tiffany Mejia

3:34 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3222-1
replied to Vendor - TEL - Arpita Srivastava

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

2:22 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

2:17 pm

Sean Nash

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

2:08 pm

Vendor - TEL - Arpita Srivastava

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE...

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

1:39 pm

Vendor - TEL - Arpita Srivastava

We can update this function as part of another Jira ticket.

We can update this function as part of another Jira ticket.

1:21 pm

Sean Nash

This one looks like maybe we could use the helper function. Have Vinay look at it.

This one looks like maybe we could use the helper function. Have Vinay look at it.

1:20 pm

Sean Nash

I don't think so. The state is bit encoded, so special handling is required.

I don't think so. The state is bit encoded, so special handling is required.

10:52 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

10:51 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Remove extra blank line.

Remove extra blank line.

10:01 am

Raghu Kallala

More
3393de3
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 added function to initialize FPGA registers with every setConfig call

- -2
- +56
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -11
- +25
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -0
- +1
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h

9:26 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

I don't think we need to check test config for variable initialization.

I don't think we need to check test config for variable initialization.

9:13 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:10 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:01 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-14 22:11 -0700