Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 32

Total Committers:	16
Last Commit:	09:33
Commits this week:	32

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 09 Feb

5:05 pm

Vinayakam Mani

More
1dadcc3
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 42 more LEAHI-DD-FIRMWARE-LDT-1473-1

firmware/App/Modes/ModeGenDialysate.c

- -0
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

5:04 pm

Vinayakam Mani

Yes. updated.

Yes. updated.

4:22 pm

Vendor - TEL - Jashwant Gantyada

This is from latest staging changes.

This is from latest staging changes.

2:03 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

2:01 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

1:59 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

1:58 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

1:39 pm

Dara Navaei

1:34 pm

Sean Nash , Michael Garthwaite and Vendor - TEL - Sameer Poyil

More
LEAHI-DD-FIRMWARE-LDT-3222-1
finished reviewing

1:30 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3222-1
started review

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides

1:12 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Align comments.

Align comments.

1:11 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

1:09 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Add space between } and type name.

Add space between } and type name.

1:08 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Indenting looks off for most fields in this struct.

Indenting looks off for most fields in this struct.

1:07 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Why doesn't name and comment match?

Why doesn't name and comment match?

10:59 am

Vendor - TEL - Arpita Srivastava

10:51 am

Michael Garthwaite

More
0bb2512
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 43 more LEAHI-DD-FIRMWARE-LDT-3173-1

WIP on LDT-3173-io-pressure-sensors

LDT-3372: implemented overrides for teensy conductivity, resistance, and temperature. Implemented init state for teensy to last 1 to prevent comm issues on power on bring up.

- -16
- +196
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c
- -4
- +8
/firmware/App/Drivers/ConductivityTeensy.h
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.h
- -0
- +8
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

9:43 am

Dara Navaei

More
c4e602a
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 46 more LEAHI-DD-FIRMWARE-LDT-2004-3 LEAHI-DD-FIRMWARE-LDT-1473-1

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

9:36 am

Dara Navaei

More
23e8d8f
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 46 more LEAHI-DD-FIRMWARE-LDT-2004-3

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -2
- +2
/firmware/App/Controllers/Valves.h
- History
- Source
- Diff
/firmware/App/Controllers/Valves.h

9:28 am

Vendor - TEL - Arpita Srivastava

More
17bfea4
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 47 more LEAHI-DD-FIRMWARE-LDT-3222-1

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3222-command-to-override-all-BC

- -2
- +43
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -1
- +11
/firmware/App/Controllers/Valves.h
- History
- Source
- Diff
/firmware/App/Controllers/Valves.h

9:24 am

Michael Garthwaite

More
82264ec
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 43 more LEAHI-DD-FIRMWARE-LDT-3173-1

Merge branch 'staging' into LDT-3173-io-pressure-sensors

- -4
- +46
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c

Sunday 08 Feb

6:59 am

Reddaiah Utti <ven.ureddaiah@diality.com>

More
04ef9dd
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 12 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for RinsePump.c file

6:56 am

Reddaiah Utti <ven.ureddaiah@diality.com>

More
aab4337
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 12 more

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for BoostPump.c file

Friday 06 Feb

8:02 pm

Vendor - TEL - Sameer Poyil

More
1013708
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 45 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 Restoring the earlier code for execGenDialysateMonitor()

- -21
- +3
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

7:35 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Ya , I forgot the coding guide line . Fixed it

Ya , I forgot the coding guide line .
Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:32 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:31 pm

Vendor - TEL - Sameer Poyil

More
e197ced
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 45 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 implementing code review comments

- -13
- +10
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -3
- +21
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-14 09:57 -0700