dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2004-3 adding drybicart fill in preg-en

    • -1
    • +7
    /firmware/App/Modes/ModePreGenDialysate.c
Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

arrange this code and new sensor code in a group- line 131 - 142

arrange this code and new sensor code in a group- line 131 - 142

I think we need a #ifdef TEENSY macro ?

I think we need a #ifdef TEENSY macro ?

Need two spaces before the test function

Need two spaces before the test function

LDT-1473 latest from staging

LDT-1473 latest from staging

    • -23
    • +19
    /firmware/App/Modes/ModeGenDialysate.c
    • -4
    • +69
    /firmware/App/Monitors/Temperature.c
firmware/App/Modes/ModeGenDialysate.c

    • -0
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
Yes. updated.

Yes. updated.

This is from latest staging changes.

This is from latest staging changes.

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
Align comments.

Align comments.

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

Add space between } and type name.

Add space between } and type name.

Indenting looks off for most fields in this struct.

Indenting looks off for most fields in this struct.

Why doesn't name and comment match?

Why doesn't name and comment match?

WIP on LDT-3173-io-pressure-sensors

LDT-3372: implemented overrides for teensy conductivity, resistance, and temperature. Implemented init state for teensy to last 1 to prevent comm issues on power on bring up.

    • -16
    • +196
    /firmware/App/Drivers/ConductivityTeensy.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3222-command-to-override-all-BC

Merge branch 'staging' into LDT-3173-io-pressure-sensors

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for RinsePump.c file

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for BoostPump.c file