Activity dd-firmware/

10:59 am

Vinayakam Mani

More
e6fef0f
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 41 more LEAHI-DD-FIRMWARE-LDT-1473-1

LDT-1473 code review comments

- -3
- +4
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -5
- +1
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -6
- +6
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c

10:50 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Add TODO to comment.

10:48 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Put () around the 2 conditions

10:03 am

Sean Nash

Does it make more sense to have them together?

10:01 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

Is there no "first" enum for this group?

10:00 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

Align comment.

9:30 am

Vendor - TEL - Jashwant Gantyada

removed.

9:30 am

Vendor - TEL - Jashwant Gantyada

updated.

9:30 am

Vendor - TEL - Jashwant Gantyada

done

9:29 am

Vendor - TEL - Jashwant Gantyada

removed.

9:29 am

Vendor - TEL - Jashwant Gantyada

More
4d1d5fc
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 19 more

LDT-3750 cherry-picked 3bafab7

- -389
- +9
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

9:29 am

Vendor - TEL - Jashwant Gantyada

More
3bafab7
changed 6 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 26 more LEAHI-DD-FIRMWARE-LDT-3103-1 LEAHI-DD-FIRMWARE-LDT-2004-11 LEAHI-DD-FIRMWARE-LDT-2004-13

LDT-3103-base logic updated for d48 closed loop control

- -4
- +0
/firmware/.settings/com.ti.ccstudio.project.core.prefs
- History
- Source
- Diff
/firmware/.../com.ti.ccstudio.project.core.prefs
- -422
- +37
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -0
- +12
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -1
- +3
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -13
- +17
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -1
- +2
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

8:36 am

Raghu Kallala

More
62b2fbf
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more

WIP replaced all get set unctions with macros

- -363
- +366
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

7:25 am

Raghu Kallala

More
fdd5d0d
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 updated function header

- -2
- +3
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

7:24 am

Raghu Kallala

Resolved

7:22 am

Raghu Kallala

Updated

7:21 am

Raghu Kallala

Updated

7:14 am

Raghu Kallala

More
dfeca71
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 added macro for FPGADD register fields

- -11
- +5
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

7:13 am

Raghu Kallala

More
4440a7a
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 added macro for FPGADD register fields

- -3
- +3
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -170
- +230
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

9:10 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

seems to be old , need to merge the staging code

9:07 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

align the comment

9:06 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

complicated check should be replaced with boolean flag

8:30 pm

Vendor - TEL - Sameer Poyil

More
1da1624
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 44 more LEAHI-DD-FIRMWARE-LDT-2004-3

LDT-2004-3 adding drybicart fill in preg-en

- -1
- +7
/firmware/App/Modes/ModePreGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreGenDialysate.c

7:45 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

Variable name is not understood -temDataCollectionTimeInterval ?

7:22 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

arrange this code and new sensor code in a group- line 131 - 142

7:19 pm

Vendor - TEL - Sameer Poyil

I think we need a #ifdef TEENSY macro ?

7:16 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3173-1
commented on review

Need two spaces before the test function

5:35 pm

Vinayakam Mani

More
d0ba073
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 41 more LEAHI-DD-FIRMWARE-LDT-1473-1

LDT-1473 latest from staging

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

5:32 pm

Vinayakam Mani

More
e163e9f
changed 8 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 41 more LEAHI-DD-FIRMWARE-LDT-1473-1

LDT-1473 latest from staging

- -8
- +8
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +6
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -1
- +1
/firmware/App/Controllers/Ultrafiltration.c
- History
- Source
- Diff
/firmware/App/.../Ultrafiltration.c
- -6
- +5
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -23
- +19
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -4
- +69
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c
- -35
- +62
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -4
- +7
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h

5:05 pm

Vinayakam Mani

More
1dadcc3
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 41 more LEAHI-DD-FIRMWARE-LDT-1473-1

firmware/App/Modes/ModeGenDialysate.c

- -0
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

dd-firmware

Stats

Commits this week: 25

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Vinayakam Mani

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Raghu Kallala

Raghu Kallala

Raghu Kallala

Raghu Kallala

Raghu Kallala

Raghu Kallala

Raghu Kallala

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vinayakam Mani

Vinayakam Mani

Vinayakam Mani