dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2004-3 Dry bicart review comments implementation

    • -1
    • +1
    /firmware/App/Modes/ModePreGenDialysate.c
LDT-3344 fixed typo

LDT-3344 updated the set and get functions with macro calls

    • -223
    • +253
    /firmware/App/Services/FpgaDD.c
Looks crucible is not seeing those. let me check once with Dara.

Looks crucible is not seeing those. let me check once with Dara.

Done.

Done.

Updated.

Updated.

Updated

Updated

LDT-1473 code review comments

Add TODO to comment.

Add TODO to comment.

Put () around the 2 conditions

Put () around the 2 conditions

Does it make more sense to have them together?

Does it make more sense to have them together?

Is there no "first" enum for this group?

Is there no "first" enum for this group?

Align comment.

Align comment.

removed.

removed.

updated.

updated.

done

done

removed.

removed.

LDT-3103-base logic updated for d48 closed loop control

    • -13
    • +17
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +2
    /firmware/App/Modes/ModeGenDialysate.h
WIP replaced all get set unctions with macros

    • -363
    • +366
    /firmware/App/Services/FpgaDD.c
LDT-3344 updated function header

Resolved

Resolved

Updated

Updated

Updated

Updated

LDT-3344 added macro for FPGADD register fields

LDT-3344 added macro for FPGADD register fields

    • -170
    • +230
    /firmware/App/Services/FpgaDD.c
seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

align the comment

align the comment

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

LDT-2004-3 adding drybicart fill in preg-en

    • -1
    • +7
    /firmware/App/Modes/ModePreGenDialysate.c
Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?