Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 31

Total Committers:	16
Last Commit:	09:33
Commits this week:	31

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 11 Feb

6:55 am

Raghu Kallala

More
8d77039
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 43 more

LDT-3480 merged into staging

6:52 am

Raghu Kallala

More
c1a20d8
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 44 more

LDT-3480 merge latest from staging

6:11 am

Vendor - TEL - Jashwant Gantyada

changed.

changed.

Tuesday 10 Feb

5:25 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

Remove blank line.

Remove blank line.

5:20 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
replied to Vendor - TEL - Jashwant Gantyada

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

5:17 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Why not "TRUE == "?

Why not "TRUE == "?

5:16 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Why not "TRUE == "?

Why not "TRUE == "?

5:15 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Remove blank line.

Remove blank line.

5:14 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Remove extra blank line.

Remove extra blank line.

5:12 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
replied to Vendor - TEL - Jashwant Gantyada

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

5:10 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Why did this file get deleted?

Why did this file get deleted?

5:03 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Add blank line between declarations and rest of code.

Add blank line between declarations and rest of code.

5:02 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Add comment to right listing which math functions we're using.

Add comment to right listing which math functions we're using.

3:33 pm

Vendor - TEL - Sameer Poyil

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

3:13 pm

Michael Garthwaite

fixed.

fixed.

3:12 pm

Michael Garthwaite

reordered and wrapped in a macro

reordered and wrapped in a macro

3:12 pm

Michael Garthwaite

see other comment.

see other comment.

3:12 pm

Michael Garthwaite

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

3:11 pm

Dara Navaei

More
bbe6b95
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

3:11 pm

Michael Garthwaite

fixed.

fixed.

3:11 pm

Michael Garthwaite

removed

removed

3:10 pm

Michael Garthwaite

fixed.

fixed.

3:10 pm

Michael Garthwaite

it stop gap to see if it was valve specific. Its been reverted.

it stop gap to see if it was valve specific. Its been reverted.

3:09 pm

Michael Garthwaite

More
4c340aa
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Merge branch 'LDT-3173-io-pressure-sensors' into develop

LDT-3372: code review comments. re ordered messaging

- -12
- +13
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

3:07 pm

Michael Garthwaite

More
8b5a8c8
changed 3 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 43 more LEAHI-DD-FIRMWARE-LDT-3173-1

LDT-3372: code review comments. fixes to valve pwm configuration. reordered msg look up table for messages in relation to teensy

- -3
- +3
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -1
- +1
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c
- -12
- +11
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

2:52 pm

Dara Navaei

More
c77fd6a
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

2:49 pm

Michael Garthwaite

More
ff5a122
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Merge branch 'LDT-3173-io-pressure-sensors' into develop

- -0
- +8
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

2:45 pm

Michael Garthwaite

More
a7bb148
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 43 more LEAHI-DD-FIRMWARE-LDT-3173-1

Merge branch 'staging' into LDT-3173-io-pressure-sensors

- -126
- +147
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -2
- +10
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

2:44 pm

Michael Garthwaite

More
ff93c14
changed 3 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd and 2 more

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

- -4
- +4
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -2
- +2
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c
- -2
- +10
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-14 09:48 -0700