dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3344 WIP for rinsepump implementations

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

LDT-2030 addressed code review comments

    • -22
    • +21
    /firmware/App/Drivers/BloodLeakDriver.h
Use #define macros for magic numbers.

Use #define macros for magic numbers.

LDT-3344 fixed the issue of conductive level sensor response

LDT-3344 fixed the issue of conductive level sensor response

LDT-2030 addressed code review comments

    • -15
    • +2
    /firmware/App/Drivers/BloodLeakDriver.c
    • -2
    • +0
    /firmware/App/Drivers/BloodLeakDriver.h
Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Remove extra blank line.

Remove extra blank line.

Add a TODO to comment then.

Add a TODO to comment then.

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

Add a blank line after declaration.

Add a blank line after declaration.

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

implement it in a single structure packing by moving all other pragma pack

implement it in a single structure packing by moving all other pragma pack

done

done

done

done

changed

changed

done

done

done

done

done

done

done.

done.

done.

done.

done.

done.

declared in the header and updated them.

declared in the header and updated them.

Resolved. Thanks

Resolved. Thanks

Resolved. Thanks

Resolved. Thanks

LDT-2030 addressed code review comments

    • -76
    • +86
    /firmware/App/Drivers/BloodLeakDriver.c
    • -0
    • +8
    /firmware/App/Drivers/BloodLeakDriver.h