Activity dd-firmware/

3:44 pm

Raghu Kallala

More
cfa8ae2
changed 4 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 WIP for rinsepump implementations

- -2
- +3
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -1
- +0
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -0
- +1
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h
- -12
- +24
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

3:43 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

3:16 pm

Vendor - TEL - Jashwant Gantyada

More
d8307ba
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 42 more LEAHI-DD-FIRMWARE-LDT-2030-2

LDT-2030 addressed code review comments

- -22
- +21
/firmware/App/Drivers/BloodLeakDriver.h
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.h

3:11 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Use #define macros for magic numbers.

2:56 pm

Raghu Kallala

More
ed2e81c
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 fixed the issue of conductive level sensor response

- -3
- +6
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

2:56 pm

Raghu Kallala

More
b4c343f
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more

LDT-3344 fixed the issue of conductive level sensor response

- -3
- +6
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

2:54 pm

Vendor - TEL - Jashwant Gantyada

More
1a1023b
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 42 more LEAHI-DD-FIRMWARE-LDT-2030-2

LDT-2030 addressed code review comments

- -15
- +2
/firmware/App/Drivers/BloodLeakDriver.c
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.c
- -2
- +0
/firmware/App/Drivers/BloodLeakDriver.h
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.h

2:29 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

2:22 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

2:18 pm