Activity dd-firmware/

3:30 pm

Vendor - TEL - Jashwant Gantyada

More
be3fa27
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 addressed code review comments

- -37
- +22
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -16
- +17
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

1:34 pm

Vinayakam Mani

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

11:22 am

Michael Garthwaite

More
df39249
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd and 2 more

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

10:19 am

Dara Navaei

More
144067b
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more LEAHI-DD-FIRMWARE-LDT-3552-1

LDT-3552 added a #define for the blood leak response buffer

- -1
- +3
/firmware/App/Drivers/BloodLeakDriver.h
- History
- Source
- Diff
/firmware/App/Drivers/BloodLeakDriver.h

10:16 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3552-1
started review

LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages

9:57 am

Raghu Kallala

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

9:54 am

Raghu Kallala

More
3019991
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 set D79 to default PWM to 45%

- -1
- +1
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c

9:27 am

Michael Garthwaite

More
dc883aa
changed 5 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

LDT-3218: init commit to have flow curve based on recovery settings.

- -0
- +5
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +14
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -0
- +1
/firmware/App/Controllers/Valves.h
- History
- Source
- Diff
/firmware/App/Controllers/Valves.h
- -1
- +0
/firmware/App/Modes/FPModes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.c
- -1
- +0
/firmware/App/Modes/FPModes/StateFlushPermeate.c
- History
- Source
- Diff
/firmware/App/.../StateFlushPermeate.c

9:23 am

Michael Garthwaite

More
433967c
changed 0 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

5:08 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Can we check some persistence before declaring alarm?

5:07 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

4:46 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3344-1
commented on review

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

4:17 pm

Vinayakam Mani

More
b342323
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-3352-dd---revisit-d3-level-control-l, develop LEAHI-DD-FIRMWARE-LDT-3352-1

LDT-3352 resolving merge conflicts

- -4
- +1
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

3:47 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Resolve merge conflicts.

1:54 pm

Michael Garthwaite

More
811395e
changed 3 files

LDT-3372: Reduced warnings in relation to teensy driver. Removed unused functions. Fixed overrides

- -131
- +28
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c
- -2
- +2
/firmware/App/Drivers/ConductivityTeensy.h
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.h
- -8
- +8
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

1:33 pm

Vendor - TEL - Jashwant Gantyada

More
f66ffb2
changed 7 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more LEAHI-DD-FIRMWARE-LDT-3344-1

LDT-3344 addressed code review comments

- -8
- +119
/firmware/App/Controllers/RinsePump.c
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.c
- -2
- +6
/firmware/App/Controllers/RinsePump.h
- History
- Source
- Diff
/firmware/App/Controllers/RinsePump.h
- -1
- +37
/firmware/App/Drivers/GPIO.c
- History
- Source
- Diff
/firmware/App/Drivers/GPIO.c
- -0
- +12
/firmware/App/Drivers/GPIO.h
- History
- Source
- Diff
/firmware/App/Drivers/GPIO.h
- -13
- +11
/firmware/App/Monitors/Level.c
- History
- Source
- Diff
/firmware/App/Monitors/Level.c
- -39
- +30
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -0
- +4
/firmware/App/Tasks/TaskPriority.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskPriority.c

12:00 pm

Michael Garthwaite

More
b91d956
changed 3 files
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd and 2 more

LDT-2004: updates to v2 driver. changed data types for cal coefficents to f32. Implemented calculated resistance, temp, and conductivity based on raw data from sensor.