dd-firmware

Clone Tools

Stats

Commits this week: 35
Total Committers: 16
Last Commit: 08:49
Commits this week: 35

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Apr
8:33 am

Raghu Kallala

LDT-3749 addressed review comments

Options
    • -1
    • +3
    /firmware/App/Modes/ModeFault.c
    • -1
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +3
    /firmware/App/Modes/ModePostGenDialysate.c
    • -1
    • +3
    /firmware/App/Modes/ModePreGenDialysate.c
    • -1
    • +3
    /firmware/App/Modes/ModeStandby.c
    • -0
    • +1
    /firmware/App/Modes/OperationModes.c
8:21 am

Raghu Kallala

You are right, modified in all places

You are right, modified in all places

Thursday 09 Apr
9:04 am

Michael Garthwaite

LDT-2008: code review comments.

Options
    • -6
    • +8
    /firmware/App/Drivers/ConductivitySensors.c
    • -1
    • +0
    /firmware/App/Monitors/Conductivity.c
Wednesday 08 Apr
5:16 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Fixed dependency between NVM files.

Options
    • -1
    • +12
    /firmware/App/Drivers/NVDriver.c
    • -0
    • +19
    /firmware/App/Drivers/NVDriver.h
    • -11
    • +27
    /firmware/App/Services/NVMgmtDD.c
    • -5
    • +11
    /firmware/App/Services/NVMgmtDD.h
    • -10
    • +22
    /firmware/App/Services/NVMsgQ.c
    • -1
    • +15
    /firmware/App/Services/NVMsgQ.h
    • -5
    • +21
    /firmware/App/Services/NVRecordsDD.c
    • -90
    • +93
    /firmware/App/Services/NVRecordsDD.h
1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments and merged latest staging

Options
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.c
1:30 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into LDT-3103-closed-loop-control-pressure-threshold-fix

Options
    • -2
    • +24
    /firmware/App/Controllers/BalancingChamber.c
    • -4
    • +18
    /firmware/App/Modes/ModeGenDialysate.c
12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:23 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:22 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:19 pm

Sean Nash

Remove blank line.

Remove blank line.

12:11 pm

Sean Nash

Why are we switching sensors around?

Why are we switching sensors around?

12:11 pm

Sean Nash

Why D43?

Why D43?

12:10 pm

Sean Nash

Remove blank line.

Remove blank line.

12:09 pm

Sean Nash

Should we be filtering a new sample every 700ms or should we do it when a new sample is received? FPGA is giving us a read count right? So we will know when we have a new data set from sensor. It m...

Should we be filtering a new sample every 700ms or should we do it when a new sample is received?
FPGA is giving us a read count right? So we will know when we have a new data set from sensor. It makes more sense to me to take them when they come. Otherwise, we will get out of phase with true sample frequency and occasionally process the previous sample again (if true sample freq is a little slower than 700ms) or miss a sample (if true sample freq is a little faster than 700ms).

12:04 pm

Sean Nash

Why do we need these static interval variables when we have the constants?

Why do we need these static interval variables when we have the constants?

12:03 pm

Sean Nash

Remove blank line.

Remove blank line.

11:14 am

Vinayakam Mani

Delete the macro if not being used.

Delete the macro if not being used.

10:03 am

Vendor - TEL - Arpita Srivastava

LDT-1195: Fixed indentation

Options
    • -3
    • +1
    /firmware/App/Controllers/BalancingChamber.c
    • -1
    • +1
    /firmware/App/Tasks/TaskGeneral.c
8:44 am

Michael Garthwaite

Merge branch 'staging' into LDT-3777-sprint-25-fixes

Options
8:24 am

Dara Navaei

Tuesday 07 Apr
2:54 pm

Vinayakam Mani

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

2:52 pm

Michael Garthwaite

LDT-2008: version request handler. fixes for D74 between test configs. reworked init state to handle sensors providing bad cal data if test config is enabled.

Options
    • -79
    • +114
    /firmware/App/Drivers/ConductivitySensors.c
    • -0
    • +1
    /firmware/App/Drivers/ConductivitySensors.h
    • -1
    • +9
    /firmware/App/Monitors/Conductivity.c
    • -1
    • +1
    /firmware/App/Monitors/Temperature.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    /firmware/App/Services/Messaging.c
2:06 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -5
    • +1
    /firmware/App/Controllers/BalancingChamber.c