dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4183 addressed code review comments

    • -48
    • +61
    /firmware/App/Controllers/DryBiCart.c
Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Addressed gaps and updated testcases as per the new build for Valves file

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Added test cases for Pressure.c and PressureCommon.c

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Added test cases for Interrupts.c file

LDT-3963 addressed code review/vinay's comments

    • -6
    • +5
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenDialysate.h
LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Addressed gaps as per new build in file DialysatePumps file

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LDT-3958 heater control update

    • -160
    • +122
    /firmware/App/Controllers/Heaters.c
    • -2
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +16
    /firmware/App/Monitors/Temperature.c
LDT-872 gain update

LDT-872 fix

LDT-872 heater control update

    • -0
    • +1
    /firmware/App/Modes/ModeGenDialysate.c
    • -9
    • +0
    /firmware/App/Modes/ModeGenDialysate.h
LDT-872 heater control update

    • -19
    • +79
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +16
    /firmware/App/Monitors/Temperature.c
Merge branch 'staging' into LDT-3975-Boost-Pump

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch LDT-4183-dialysate-composition-dry-bicar into develop

LDT-4183 increasing max drybicart pressure to 20 PSI for beta 2.1

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Modified test cases as per new build for Heaters.c file

Use the get Acid mix control interval?

Use the get Acid mix control interval?

Updates the comments for all new variables.

Updates the comments for all new variables.

Remove this flag.

Remove this flag.

Remove this code.

Remove this code.

There should be a \b before the type of details (Inputs and Outputs here) for documentation please update for all

There should be a \b before the type of details (Inputs and Outputs here) for documentation please update for all