dd-firmware

Clone Tools

Stats

Commits this week: 35
Total Committers: 20
Last Commit: 11:36
Commits this week: 35

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Jun
5:03 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Added function wrappers for public functions

Options
    • -1
    • +1
    /firmware/App/Controllers/BoostPump.c
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.h
    • -1
    • +1
    /firmware/App/Controllers/DialysatePumps.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -13
    • +13
    /firmware/App/Drivers/NVDriver.h
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -111
    • +191
    /firmware/App/Services/NVMgmtDD.c
    • -0
    • +6
    /firmware/App/Services/NVMgmtDD.h
    • -97
    • +283
    /firmware/App/Services/NVMsgQ.c
    • -1
    • +1
    /firmware/App/Services/NVMsgQ.h
    • -23
    • +24
    /firmware/App/Services/NVRecordsDD.c
  16. … 4 more files in changeset.
2:35 pm

Vendor - TEL - Jashwant Gantyada

remove blank lines

remove blank lines

2:29 pm

Vendor - TEL - Jashwant Gantyada

Align comment

Align comment

2:26 pm

Sean Nash

Put TRUE on left side of ==

Put TRUE on left side of ==

2:21 pm

Sean Nash

"u" comes before "y".

"u" comes before "y".

2:18 pm

Sean Nash

BROADCAST_INTERVAL?

BROADCAST_INTERVAL?

1:48 pm

Michael Garthwaite

removed

removed

1:48 pm

Michael Garthwaite

pre-gen does not need substitution rate as its only treatment related.

pre-gen does not need substitution rate as its only treatment related.

1:47 pm

Michael Garthwaite

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

1:46 pm

Michael Garthwaite

removed

removed

1:45 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Monitors/Temperature.c
1:15 pm

Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Sameer Poyil

1:09 pm

Vendor - TEL - Sameer Poyil

is it a dummy parameter? where are you using it ?

is it a dummy parameter? where are you using it ?

1:08 pm

Vendor - TEL - Sameer Poyil

Why pre-gen missing substitutionrate ? not required ?

Why pre-gen missing substitutionrate ? not required ?

1:00 pm

Vendor - TEL - Sameer Poyil

please removed commented code

please removed commented code

12:59 pm

Vendor - TEL - Sameer Poyil

please remove commented code

please remove commented code

12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:02 pm

Vinayakam Mani

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

12:01 pm

Michael Garthwaite

added

added

12:01 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:01 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:01 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:01 pm

Michael Garthwaite

added.

added.

12:00 pm

Michael Garthwaite

renamed to reflect whats on staging

renamed to reflect whats on staging

12:00 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:00 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:00 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/SubstitutionPump.c
    • -0
    • +2
    /firmware/App/Services/FpgaDD.c
    • -41
    • +68
    /firmware/App/Services/TDInterface.c
11:57 am

Vinayakam Mani

update the message ID.

update the message ID.

11:53 am

Vinayakam Mani

Update the comment for all publish counter start counts.

Update the comment for all publish counter start counts.