dd-firmware

Clone Tools

Stats

Commits this week: 33
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 33

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Jun
5:03 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Added function wrappers for public functions

Options
    • -1
    • +1
    /firmware/App/Controllers/BoostPump.c
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.h
    • -1
    • +1
    /firmware/App/Controllers/DialysatePumps.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -13
    • +13
    /firmware/App/Drivers/NVDriver.h
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -111
    • +191
    /firmware/App/Services/NVMgmtDD.c
    • -0
    • +6
    /firmware/App/Services/NVMgmtDD.h
    • -97
    • +283
    /firmware/App/Services/NVMsgQ.c
    • -1
    • +1
    /firmware/App/Services/NVMsgQ.h
    • -23
    • +24
    /firmware/App/Services/NVRecordsDD.c
  16. … 4 more files in changeset.
4:05 pm

Vinayakam Mani

fix the typo in 'persistence' across the file.

fix the typo in 'persistence' across the file.

4:00 pm

Vinayakam Mani

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

3:56 pm

Vinayakam Mani

Check pressure limit.

Check pressure limit.

3:50 pm

Vinayakam Mani

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

3:45 pm

Vinayakam Mani

Is this code updated for B2.1 fill implementation?

Is this code updated for B2.1 fill implementation?

3:33 pm

Vinayakam Mani

Update Inputs and outputs.

Update Inputs and outputs.

3:29 pm

Vinayakam Mani

fix the typo.

fix the typo.

3:19 pm

Vinayakam Mani

declare a local variable to get these function values and use the variables here?

declare a local variable to get these function values and use the variables here?

3:18 pm

Vinayakam Mani

remove blank space before =

remove blank space before =

3:15 pm

Vinayakam Mani

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

3:11 pm

Vinayakam Mani

Same as above.

Same as above.

3:10 pm

Vinayakam Mani

Can we keep getBicarbMixControlInterval( removing drybicart) from the function name?

Can we keep getBicarbMixControlInterval( removing drybicart) from the function name?

2:54 pm

Vinayakam Mani

Do we need to call updateDryBicartOperation() here to determine the appropriate state.

Do we need to call updateDryBicartOperation() here to determine the appropriate state.

2:35 pm

Vendor - TEL - Jashwant Gantyada

remove blank lines

remove blank lines

2:29 pm

Vendor - TEL - Jashwant Gantyada

Align comment

Align comment

2:29 pm

Vinayakam Mani

function adjusts the volume of acid and bicarb based on the target conductivity of bicarb and dialysate solution?

function adjusts the volume of acid and bicarb based on the target conductivity of bicarb and dialysate solution?

2:26 pm

Sean Nash

Put TRUE on left side of ==

Put TRUE on left side of ==

2:21 pm

Sean Nash

"u" comes before "y".

"u" comes before "y".

2:20 pm

Vinayakam Mani

Add alarm message.

Add alarm message.

2:18 pm

Sean Nash

BROADCAST_INTERVAL?

BROADCAST_INTERVAL?

2:18 pm

Vinayakam Mani

Remove the commented code and add the comment for below function

Remove the commented code and add the comment for below function

2:14 pm

Vinayakam Mani

As suggested earlier in other code review, split this function into few init functions and call it here.

As suggested earlier in other code review, split this function into few init functions and call it here.

1:48 pm

Michael Garthwaite

removed

removed

1:48 pm

Michael Garthwaite

pre-gen does not need substitution rate as its only treatment related.

pre-gen does not need substitution rate as its only treatment related.

1:47 pm

Michael Garthwaite

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

1:46 pm

Michael Garthwaite

removed

removed

1:45 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Monitors/Temperature.c
1:15 pm

Vendor - TEL - Sameer Poyil

1:09 pm

Vendor - TEL - Sameer Poyil

is it a dummy parameter? where are you using it ?

is it a dummy parameter? where are you using it ?