dd-firmware

Clone Tools

Stats

Commits this week: 33
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 33

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Jun
1:18 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Services/Messaging.c
9:22 am

Vendor - TEL - Sameer Poyil

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Tuesday 09 Jun
10:29 pm

Vinayakam Mani

why TODO?

why TODO?

10:24 pm

Vinayakam Mani

Do we need to close D64 as well?

Do we need to close D64 as well?

10:23 pm

Vinayakam Mani

Delete the commented line

Delete the commented line

10:17 pm

Vinayakam Mani

handleBicarbChamberInitiateSupply?

handleBicarbChamberInitiateSupply?

10:15 pm

Vinayakam Mani

Update this.

Update this.

10:14 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

10:13 pm

Vinayakam Mani

Update Inputs and Outputs throughout the file.

Update Inputs and Outputs throughout the file.

10:06 pm

Vinayakam Mani

Do we need this?

Do we need this?

10:05 pm

Vinayakam Mani

when are we closing D64 valve? handle the same in else block as well.

when are we closing D64 valve? handle the same in else block as well.

9:56 pm

Vinayakam Mani

Can this be assigned during declaration time?

Can this be assigned during declaration time?

9:43 pm

Vinayakam Mani

are we using these?

are we using these?

9:29 pm

Vinayakam Mani

Can we use one macro (instead of three) for the D66 persistence?

Can we use one macro (instead of three) for the D66 persistence?

9:24 pm

Vinayakam Mani

The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.

The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.

9:21 pm

Vinayakam Mani

Dry bicart data publish in the comment.

Dry bicart data publish in the comment.

5:03 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Added function wrappers for public functions

Options
    • -1
    • +1
    /firmware/App/Controllers/BoostPump.c
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.h
    • -1
    • +1
    /firmware/App/Controllers/DialysatePumps.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -13
    • +13
    /firmware/App/Drivers/NVDriver.h
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -111
    • +191
    /firmware/App/Services/NVMgmtDD.c
    • -0
    • +6
    /firmware/App/Services/NVMgmtDD.h
    • -97
    • +283
    /firmware/App/Services/NVMsgQ.c
    • -1
    • +1
    /firmware/App/Services/NVMsgQ.h
    • -23
    • +24
    /firmware/App/Services/NVRecordsDD.c
  16. … 4 more files in changeset.
4:05 pm

Vinayakam Mani

fix the typo in 'persistence' across the file.

fix the typo in 'persistence' across the file.

4:00 pm

Vinayakam Mani

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

3:56 pm

Vinayakam Mani

Check pressure limit.

Check pressure limit.

3:50 pm

Vinayakam Mani

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

3:45 pm

Vinayakam Mani

Is this code updated for B2.1 fill implementation?

Is this code updated for B2.1 fill implementation?

3:33 pm

Vinayakam Mani

Update Inputs and outputs.

Update Inputs and outputs.

3:29 pm

Vinayakam Mani

fix the typo.

fix the typo.

3:19 pm

Vinayakam Mani

declare a local variable to get these function values and use the variables here?

declare a local variable to get these function values and use the variables here?

3:18 pm

Vinayakam Mani

remove blank space before =

remove blank space before =

3:15 pm

Vinayakam Mani

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

3:11 pm

Vinayakam Mani

Same as above.

Same as above.

3:10 pm

Vinayakam Mani

Can we keep getBicarbMixControlInterval( removing drybicart) from the function name?

Can we keep getBicarbMixControlInterval( removing drybicart) from the function name?

2:54 pm

Vinayakam Mani

Do we need to call updateDryBicartOperation() here to determine the appropriate state.

Do we need to call updateDryBicartOperation() here to determine the appropriate state.