RinsePump.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Done

Done

comments should start with capital letter

comments should start with capital letter

Move up with other controllers.

Move up with other controllers.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
LDT-2329 rinse pump initial PWM update

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states? I would recommend we combine these 3 ...

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states?

I would recommend we combine these 3 fpga functions into one single function that takes all 3 params and updates all 3 registers.

I think these should be initialized to zero in case there are unused bits that won't be set below.

I think these should be initialized to zero in case there are unused bits that won't be set below.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

LDT-2329 4 wire rinse pump changes

  1. … 7 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

Align comments in all of this switch cases

Align comments in all of this switch cases

Done.

Done.

LDT-2198 rinse pump control

  1. … 6 more files in changeset.
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Done

Done