dd-firmware / firmware / App / Controllers

Valves.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 7
Last Commit: 10:37
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb
3:12 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Valves.h
  2. … 1 more file in changeset.
2:46 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

2:41 pm

Sean Nash

Thursday 19 Feb
11:24 am

Dara Navaei

LDT-3552 updated the array of the DD valves structure

Options
    • -6
    • +1
    ./Valves.h
Tuesday 17 Feb
10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages
LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages
9:27 am

Michael Garthwaite

LDT-3218: init commit to have flow curve based on recovery settings.

Options
    • -0
    • +1
    ./Valves.h
  2. … 4 more files in changeset.
Wednesday 11 Feb
1:49 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
Monday 09 Feb
1:39 pm

Dara Navaei

1:34 pm

Sean Nash , Michael Garthwaite and Vendor - TEL - Sameer Poyil

1:30 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
10:59 am

Vendor - TEL - Arpita Srivastava

9:36 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Valves.h
  2. … 1 more file in changeset.
9:28 am

Vendor - TEL - Arpita Srivastava

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3222-command-to-override-all-BC

Options
    • -1
    • +11
    ./Valves.h
  2. … 1 more file in changeset.
Friday 06 Feb
3:34 pm

Vinayakam Mani

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

2:08 pm

Vendor - TEL - Arpita Srivastava

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE...

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

1:39 pm

Vendor - TEL - Arpita Srivastava

We can update this function as part of another Jira ticket.

We can update this function as part of another Jira ticket.

1:21 pm

Sean Nash

This one looks like maybe we could use the helper function. Have Vinay look at it.

This one looks like maybe we could use the helper function. Have Vinay look at it.

1:20 pm

Sean Nash

I don't think so. The state is bit encoded, so special handling is required.

I don't think so. The state is bit encoded, so special handling is required.

Thursday 05 Feb
3:44 pm

Dara Navaei

Merged staging

Options
    • -1
    • +11
    ./Valves.h
  2. … 4 more files in changeset.
Wednesday 04 Feb
11:36 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Valves.h
  2. … 8 more files in changeset.
11:34 am

Raghu Kallala

11:30 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

6:24 am

Raghu Kallala

Updated

Updated

6:23 am

Raghu Kallala

Fixed

Fixed

Tuesday 03 Feb
5:02 pm

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

5:01 pm

Vendor - TEL - Sameer Poyil

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

4:48 pm

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

4:41 pm

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

4:38 pm

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

3:00 pm

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).