dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 11
Total Committers: 13
Last Commit: 11:18
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 May
11:25 am

Vendor - TEL - Jashwant Gantyada

merged LDT-3963 and resolved merge conflicts

Options
    • -3
    • +13
    ./BalancingChamber.c
    • -0
    • +1
    ./DryBiCart.h
  3. … 1 more file in changeset.
11:22 am

Vendor - TEL - Jashwant Gantyada

LDT-3963 added potential fix for RO loop study issue for drybicarb

Options
    • -3
    • +13
    ./BalancingChamber.c
    • -0
    • +1
    ./DryBiCart.h
Thursday 14 May
7:21 pm

Vendor - TEL - Sameer Poyil

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

6:02 pm

Vendor - TEL - Sameer Poyil

5:44 pm

Vinayakam Mani

LDT-3958 heater control update

Options
    • -1
    • +1
    ./BalancingChamber.c
    • -20
    • +80
    ./Heaters.c
  3. … 4 more files in changeset.
2:36 pm

Vendor - TEL - Jashwant Gantyada

I had this commented again to push to the develop branch. It is uncommented for my testing.

I had this commented again to push to the develop branch. It is uncommented for my testing.

2:31 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-3963 into develop

Options
    • -92
    • +219
    ./BalancingChamber.c
    • -4
    • +17
    ./ConcentratePumps.c
    • -2
    • +3
    ./RinsePump.c
  4. … 4 more files in changeset.
2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

makes sense. removed it.

2:19 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 code changes and addressed ccode review comments

Options
    • -11
    • +15
    ./BalancingChamber.c
    • -4
    • +16
    ./ConcentratePumps.c
  3. … 6 more files in changeset.
1:25 pm

Vendor - TEL - Jashwant Gantyada

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

1:07 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

Tuesday 12 May
1:50 pm

Vendor - TEL - Sameer Poyil

This dead band control ? here is the ideal place , may be BC to incldue the .h from drybicart

This dead band control ? here is the ideal place , may be BC to incldue the .h from drybicart

10:31 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content
LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content
Monday 11 May
11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

11:14 am

Vinayakam Mani

LDT-3958 reolving merge conflicts

Options
    • -159
    • +113
    ./Heaters.c
    • -1
    • +5
    ./Ultrafiltration.c
  3. … 4 more files in changeset.
10:34 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -16
    • +10
    ./Heaters.c
10:33 am

Vinayakam Mani

LDT-3958 heater control update

Options
    • -18
    • +12
    ./Heaters.c
9:12 am

Sean Nash

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Sunday 10 May
11:28 pm

Vendor - TEL - Sameer Poyil

Saturday 09 May
10:21 pm

Vendor - TEL - Sameer Poyil

LDT-4183 addressed code review comments

Options
    • -48
    • +61
    ./DryBiCart.c
    • -1
    • +0
    ./DryBiCart.h
Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Thursday 07 May
2:29 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review/vinay's comments

Options
    • -149
    • +94
    ./BalancingChamber.c
  2. … 2 more files in changeset.
Wednesday 06 May
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2: