dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 9
Total Committers: 14
Last Commit: 12:10
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 May
7:49 am

Vendor - TEL - Sameer Poyil

LDT-4183-dry bicart firmeware implementation2/1: for dialysis calculator

Options
    • -18
    • +81
    ./DryBiCart.c
Thursday 21 May
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments and restored the fault mode transition

Options
    • -40
    • +19
    ./BalancingChamber.c
    • -2
    • +1
    ./BalancingChamber.h
    • -2
    • +2
    ./ConcentratePumps.c
  4. … 7 more files in changeset.
Wednesday 20 May
2:30 pm

Raghu Kallala

10:44 am

Michael Garthwaite

Merge branch 'staging' into LDT-4000-hdf-fw-implementation-1

Options
    • -20
    • +24
    ./RinsePump.c
  2. … 1 more file in changeset.
10:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./RinsePump.c
  2. … 5 more files in changeset.
Tuesday 19 May
5:50 pm

Vinayakam Mani and Sean Nash

3:05 pm

Raghu Kallala

resolved merge conflict for LDT-4413 into develop in handleRinsePumpOffState

Options
    • -13
    • +22
    ./RinsePump.c
  2. … 1 more file in changeset.
2:19 pm

Raghu Kallala

Fixed broadcast issue for rinse pump PWM

Options
    • -6
    • +10
    ./RinsePump.c
Monday 18 May
2:59 pm

Raghu Kallala

LDT-4414 added fix to update the pwm value in broadcast and changed setpwm from count to percentage

Options
    • -10
    • +15
    ./RinsePump.c
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

11:06 pm

Sean Nash

There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?

There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?

10:59 pm

Sean Nash

Should we set this flag to FALSE at top of loop?

Should we set this flag to FALSE at top of loop?

10:58 pm

Sean Nash

Should we just set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

10:50 pm

Sean Nash

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

10:47 pm

Sean Nash

Update comment.

Update comment.

10:46 pm

Sean Nash

Is this eventually going to be d1Temp?

Is this eventually going to be d1Temp?

10:42 pm

Sean Nash

Friday 15 May
11:36 am

Vinayakam Mani

align the indent.

align the indent.