dd-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 14
Total Committers: 13
Last Commit: 30 Jul 24
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Feb
9:10 pm

Vendor - TEL - Sameer Poyil

seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

9:07 pm

Vendor - TEL - Sameer Poyil

align the comment

align the comment

9:06 pm

Vendor - TEL - Sameer Poyil

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

7:45 pm

Vendor - TEL - Sameer Poyil

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

5:04 pm

Vinayakam Mani

Yes. updated.

Yes. updated.

4:22 pm

Vendor - TEL - Jashwant Gantyada

This is from latest staging changes.

This is from latest staging changes.

Friday 06 Feb
7:35 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Ya , I forgot the coding guide line . Fixed it

Ya , I forgot the coding guide line .
Fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

7:34 pm

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

7:32 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:56 pm

Sean Nash

2:22 pm

Sean Nash

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

2:17 pm

Sean Nash

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

10:52 am

Sean Nash

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

10:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:26 am

Vinayakam Mani

I don't think we need to check test config for variable initialization.

I don't think we need to check test config for variable initialization.

9:13 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:10 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:04 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:03 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

9:01 am

Vendor - TEL - Sameer Poyil

fixed it

fixed it

Thursday 05 Feb
7:27 pm

Vendor - TEL - Sameer Poyil

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

7:24 pm

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

1:01 pm

Sean Nash

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

12:53 pm

Sean Nash

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

11:03 am

Vinayakam Mani

Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

10:24 am

Vinayakam Mani

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.