dd-firmware / firmware / App / Services

FpgaDD.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 5
Last Commit: 11 Dec
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Dec
4:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -4
    • +4
    ./FpgaDD.c
  2. … 121 more files in changeset.
Tuesday 09 Dec
11:24 am

Dara Navaei

11:20 am

Sean Nash and Vendor - TEL - Sameer Poyil

11:19 am

Dara Navaei

11:15 am

Dara Navaei

Done

Done

11:12 am

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

Monday 08 Dec
1:02 pm

Sean Nash

Move up with other controllers.

Move up with other controllers.

12:56 pm

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

12:55 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:22 am

Michael Garthwaite

LDT-1773: Valve pwm implementation for beta.

Options
    • -35
    • +348
    ./FpgaDD.c
  2. … 2 more files in changeset.
Friday 05 Dec
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -4
    • +4
    ./FpgaDD.c
  2. … 121 more files in changeset.
Monday 17 Nov
9:32 am

Vinayakam Mani

LDT-2329 spent chamber fill fix

Options
    • -2
    • +24
    ./FpgaDD.c
  2. … 4 more files in changeset.
Friday 14 Nov
5:03 pm

Sean Nash

3:19 pm

Raghu Kallala , Vinayakam Mani and Dara Navaei

11:26 am

Dara Navaei

LDT-2662 addressed the code review comments

Options
    • -5
    • +0
    ./FpgaDD.c
  2. … 3 more files in changeset.
11:24 am

Dara Navaei

Done

Done

11:23 am

Dara Navaei

No I removed it.

No I removed it.

10:56 am

Sean Nash

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

Thursday 13 Nov
4:02 pm

Vinayakam Mani

LDT-2662 spent chamber fill mode

Options
    • -4
    • +26
    ./FpgaDD.c
  2. … 6 more files in changeset.
9:56 am

Michael Garthwaite

fixed. thanks

fixed. thanks

9:15 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should be a s...

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:09 am

Michael Garthwaite

fixed. thanks

fixed. thanks

Wednesday 12 Nov
10:28 pm

Sean Nash

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

3:23 pm

Michael Garthwaite

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

3:23 pm

Michael Garthwaite

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

1:51 pm

Michael Garthwaite

reworked to use the request stop functions in their respective op modes.

reworked to use the request stop functions in their respective op modes.

1:51 pm

Michael Garthwaite

reworked to use the request functions we have in the respective op modes. They check the standby constraint

reworked to use the request functions we have in the respective op modes. They check the standby constraint

1:50 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!