dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 9
Total Committers: 15
Last Commit: 12:10
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 17 May
3:09 pm

Dara Navaei

LDT-3272 updated the size of the comm buffers

Options
    • -2
    • +2
    ./SystemCommDD.h
Friday 15 May
11:36 am

Vinayakam Mani

align the indent.

align the indent.

11:33 am

Vinayakam Mani

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Thursday 14 May
7:21 pm

Vendor - TEL - Sameer Poyil

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

6:02 pm

Vendor - TEL - Sameer Poyil

2:36 pm

Vendor - TEL - Jashwant Gantyada

I had this commented again to push to the develop branch. It is uncommented for my testing.

I had this commented again to push to the develop branch. It is uncommented for my testing.

2:25 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 commented fault mode transition for merging to develop

Options
    • -1
    • +1
    ./AlarmMgmtDD.c
2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

makes sense. removed it.

2:19 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 code changes and addressed ccode review comments

Options
    • -1
    • +1
    ./SystemCommDD.c
  2. … 7 more files in changeset.
1:25 pm

Vendor - TEL - Jashwant Gantyada

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

1:07 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

Monday 11 May
11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

11:14 am

Vinayakam Mani

LDT-3958 reolving merge conflicts

Options
    • -2
    • +2
    ./TDInterface.c
  2. … 5 more files in changeset.
9:48 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./TDInterface.c
9:42 am

Raghu Kallala

9:39 am

Raghu Kallala

LDT-4188 merge latest from staging

Options
    • -2
    • +2
    ./TDInterface.c
8:51 am

Sean Nash

Sunday 10 May
11:30 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -0
    • +16
    ./SystemCommDD.h
  2. … 2 more files in changeset.
Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Wednesday 06 May
12:46 pm

Vinayakam Mani

LDT-872 fix

Options
    • -1
    • +2
    ./Messaging.c
9:59 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -3
    • +6
    ./TDInterface.c
  2. … 2 more files in changeset.
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Tuesday 05 May
12:35 pm

Vinayakam Mani

Remove this flag.

Remove this flag.