Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

add new valves.

add new valves.

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

typo - used.

typo - used.

Add as HDF hallsensor. start the comment with capital letter R.

Add as HDF hallsensor. start the comment with capital letter R.

#define 0U across the file.

#define 0U across the file.

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we nee...

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

resolved merge conflicts

Add a variable to convert PWM count to target speed for monitor function.

Add a variable to convert PWM count to target speed for monitor function.

LDT-3344 WIP for rinsepump implementations

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

LDT-2030 addressed code review comments

Use #define macros for magic numbers.

Use #define macros for magic numbers.

LDT-3344 fixed the issue of conductive level sensor response

LDT-3344 fixed the issue of conductive level sensor response

LDT-2030 addressed code review comments

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Remove extra blank line.

Remove extra blank line.

Add a TODO to comment then.

Add a TODO to comment then.

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

Add a blank line after declaration.

Add a blank line after declaration.

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0