dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 20
Total Committers: 15
Last Commit: 19 Feb
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Feb
5:00 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
4:56 pm

Vinayakam Mani

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

4:56 pm

Vendor - TEL - Jashwant Gantyada

4:55 pm

Sean Nash and Vendor - TEL - Sameer Poyil

4:55 pm

Vinayakam Mani

add new valves.

add new valves.

4:53 pm

Vinayakam Mani

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

4:50 pm

Vinayakam Mani

typo - used.

typo - used.

4:46 pm

Vinayakam Mani

Add as HDF hallsensor. start the comment with capital letter R.

Add as HDF hallsensor. start the comment with capital letter R.

4:30 pm

Vinayakam Mani

#define 0U across the file.

#define 0U across the file.

4:18 pm

Vinayakam Mani

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we nee...

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

3:56 pm

Vinayakam Mani

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

3:51 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
3:50 pm

Raghu Kallala

resolved merge conflicts

Options
    • -1
    • +1
    ./Controllers/Valves.c
    • -123
    • +148
    ./Monitors/Level.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
3:50 pm

Vinayakam Mani

Add a variable to convert PWM count to target speed for monitor function.

Add a variable to convert PWM count to target speed for monitor function.

3:44 pm

Raghu Kallala

LDT-3344 WIP for rinsepump implementations

Options
    • -2
    • +3
    ./Controllers/RinsePump.c
    • -1
    • +0
    ./Monitors/Level.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -12
    • +24
    ./Services/FpgaDD.c
3:43 pm

Vinayakam Mani

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

3:16 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -22
    • +21
    ./Drivers/BloodLeakDriver.h
3:11 pm

Vinayakam Mani

Use #define macros for magic numbers.

Use #define macros for magic numbers.

2:56 pm

Raghu Kallala

LDT-3344 fixed the issue of conductive level sensor response

Options
    • -3
    • +6
    ./Services/FpgaDD.c
2:56 pm

Raghu Kallala

LDT-3344 fixed the issue of conductive level sensor response

Options
    • -3
    • +6
    ./Services/FpgaDD.c
2:54 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -15
    • +2
    ./Drivers/BloodLeakDriver.c
    • -2
    • +0
    ./Drivers/BloodLeakDriver.h
2:29 pm

Sean Nash

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

2:22 pm

Sean Nash

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

2:18 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:17 pm

Sean Nash

Add a TODO to comment then.

Add a TODO to comment then.

2:02 pm

Sean Nash

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

2:01 pm

Sean Nash

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

2:00 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

1:57 pm

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

1:57 pm

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0