dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 26
Total Committers: 15
Last Commit: 10:37
Commits this week: 26

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Feb
4:22 pm

Vinayakam Mani

LDT-1477 resolving merge conflicts

Options
    • -1
    • +1
    ./Controllers/Valves.c
    • -15
    • +23
    ./Services/FpgaDD.c
    • -8
    • +8
    ./Services/FpgaDD.h
    • -2
    • +2
    ./Services/Messaging.c
3:46 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation
3:32 pm

Vinayakam Mani

LDT-1477 UF update

Options
    • -13
    • +28
    ./Controllers/Ultrafiltration.c
    • -0
    • +1
    ./Monitors/Temperature.h
1:01 pm

Raghu Kallala

They were removed accidentally is what my understanding is, identify issued after commit cfa8ae2. reverted the changes with cherry picking the commits

They were removed accidentally is what my understanding is, identify issued after commit cfa8ae2.
reverted the changes with cherry picking the commits

1:00 pm

Raghu Kallala

Updated

Updated

1:00 pm

Raghu Kallala

Updated

Updated

12:59 pm

Raghu Kallala

the fix has been reverted

the fix has been reverted

12:59 pm

Raghu Kallala

As discussed, this will be done after we stabilize to single fpga structure. To avoid multiple line changes.

As discussed, this will be done after we stabilize to single fpga structure. To avoid multiple line changes.

11:57 am

Michael Garthwaite

LDT-3344 WIP for rinsepump implementations

Options
    • -12
    • +24
    ./Services/FpgaDD.c
11:55 am

Michael Garthwaite

LDT3344 updated rinsepump to work for beta1 and beta2

Options
    • -4
    • +7
    ./Monitors/Level.c
    • -2
    • +1
    ./Services/FpgaDD.c
11:28 am

Vendor - TEL - Sameer Poyil

There is a standardized level checking logic proposed , please check with Noe

There is a standardized level checking logic proposed , please check with Noe

11:27 am

Vendor - TEL - Sameer Poyil

please use FPGA version function to initialize or handle HW version

please use FPGA version function to initialize or handle HW version

11:24 am

Vendor - TEL - Sameer Poyil

read the FPGA ID and initialize it

read the FPGA ID and initialize it

11:24 am

Dara Navaei

LDT-3552 updated the array of the DD valves structure

Options
    • -6
    • +1
    ./Controllers/Valves.h
11:23 am

Vendor - TEL - Sameer Poyil

remove #if 1 and add a TODO with this comment

remove #if 1 and add a TODO with this comment

11:22 am

Vendor - TEL - Sameer Poyil

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

10:11 am

Sean Nash

I suspect this is temporary. If so, just add a TODO comment to restore later.

I suspect this is temporary. If so, just add a TODO comment to restore later.

Wednesday 18 Feb
3:52 pm

Sean Nash

Only 1 return per function.

Only 1 return per function.

3:50 pm

Sean Nash

If result is U08, why are we returning U16?

If result is U08, why are we returning U16?

3:49 pm

Sean Nash

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

3:49 pm

Sean Nash

Only 1 return statement per function.

Only 1 return statement per function.

3:43 pm

Sean Nash

Fix alignment of all of the | separators.

Fix alignment of all of the | separators.

3:43 pm

Sean Nash

This table should be sorted, so this row needs to be moved up now.

This table should be sorted, so this row needs to be moved up now.

3:42 pm

Sean Nash

Fix alignment.

Fix alignment.

3:41 pm

Sean Nash

Why remove these functions. All static functions should be prototyped up here.

Why remove these functions. All static functions should be prototyped up here.

3:40 pm

Sean Nash

S in status should be capitalized.

S in status should be capitalized.

3:36 pm

Sean Nash

Any reason why pwmInCount can't just be a U32?

Any reason why pwmInCount can't just be a U32?

3:28 pm

Sean Nash

Do we really need a start state? Can't we just start in off state.

Do we really need a start state? Can't we just start in off state.

3:27 pm

Sean Nash

Add detail for alarm.

Add detail for alarm.

3:27 pm

Sean Nash

Remove extra spaces before =.

Remove extra spaces before =.