dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 44
Total Committers: 16
Last Commit: 16:40
Commits this week: 44

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Apr
10:21 am

Michael Garthwaite

LDT-3777: code review comments and updated sample filtering to be dynamic on read counter rather than fixed interval.

Options
    • -1
    • +88
    ./Drivers/ConductivitySensors.c
    • -0
    • +2
    ./Drivers/ConductivitySensors.h
    • -36
    • +57
    ./Monitors/Conductivity.c
9:33 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:32 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Heaters.c
    • -2
    • +2
    ./DDCommon.h
    • -2
    • +2
    ./Drivers/ConductivitySensors.c
    • -2
    • +2
    ./Drivers/ConductivitySensors.h
    • -2
    • +2
    ./Drivers/ConductivityTeensy.c
    • -1
    • +1
    ./Drivers/ConductivityTeensy.h
    • -1
    • +1
    ./Monitors/Conductivity.c
    • -1
    • +1
    ./Monitors/Conductivity.h
    • -1
    • +1
    ./Monitors/Temperature.c
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/FpgaDD.c
    • -2
    • +2
    ./Services/FpgaDD.h
    • -1
    • +1
    ./Services/Interrupts.c
    • -2
    • +2
    ./Services/Messaging.c
9:32 am

Michael Garthwaite

Merge branch 'staging' into LDT-3777-sprint-25-fixes

Options
    • -17
    • +76
    ./Monitors/Conductivity.c
    • -27
    • +25
    ./Monitors/Temperature.c
9:24 am

Michael Garthwaite

9:24 am

Vendor - TEL - Sameer Poyil and Sean Nash

8:40 am

Michael Garthwaite

LDT-2008: code review comments.

Options
    • -6
    • +6
    ./Drivers/ConductivitySensors.c
8:39 am

Michael Garthwaite

per formatting for the test support function header. it is format used across many files

per formatting for the test support function header. it is format used across many files

8:36 am

Michael Garthwaite

fixed

fixed

8:36 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

fixed

fixed

8:35 am

Michael Garthwaite

Merge branch 'staging' into LDT-2008-v2-conductivity-sensors-CLEAN

Options
    • -1
    • +1
    ./DDCommon.h
8:34 am

Michael Garthwaite

LDT-2008: code review comments

Options
    • -10
    • +10
    ./Drivers/ConductivitySensors.h
    • -0
    • +1
    ./Drivers/ConductivityTeensy.c
    • -10
    • +10
    ./Drivers/ConductivityTeensy.h
8:34 am

Michael Garthwaite

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

Monday 13 Apr
5:28 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Updated logic to send record to dialin

Options
    • -0
    • +2
    ./Services/Messaging.c
    • -92
    • +203
    ./Services/NVMsgQ.c
    • -1
    • +2
    ./Services/NVMsgQ.h
4:03 pm

Vendor - TEL - Sameer Poyil

Dry bicart closed loop

Options
    • -6
    • +7
    ./Controllers/BalancingChamber.c
    • -331
    • +457
    ./Controllers/DryBiCart.c
    • -25
    • +20
    ./Controllers/DryBiCart.h
    • -1
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -3
    • +3
    ./Services/FpgaDD.c
    • -4
    • +6
    ./Services/Messaging.c
2:58 pm

Vinayakam Mani

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

12:00 pm

Vinayakam Mani

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:56 am

Vinayakam Mani

Done.

Done.

11:56 am

Vinayakam Mani

Done.

Done.

11:54 am

Vinayakam Mani

LDT-3352 code review comments update

Options
    • -11
    • +9
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/Ultrafiltration.c
    • -4
    • +6
    ./Drivers/TemperatureSensors.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
    • -53
    • +20
    ./Monitors/Temperature.c
    • -5
    • +1
    ./Monitors/Temperature.h
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
Friday 10 Apr
3:01 pm

Vendor - TEL - Jashwant Gantyada

1:48 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h