dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 21
Total Committers: 16
Last Commit: 12 May
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 11 May
10:33 am

Vinayakam Mani

LDT-3958 heater control update

Options
    • -18
    • +12
    ./Controllers/Heaters.c
9:48 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:48 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Services/TDInterface.c
9:42 am

Raghu Kallala

9:39 am

Raghu Kallala

LDT-4188 merge latest from staging

Options
    • -2
    • +2
    ./Services/TDInterface.c
9:12 am

Sean Nash

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

8:51 am

Sean Nash

Sunday 10 May
11:30 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -4
    • +4
    ./DDCommon.h
11:30 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Monitors/Level.c
    • -1
    • +1
    ./Monitors/Level.h
    • -0
    • +16
    ./Services/SystemCommDD.h
11:30 pm

Vendor - TEL - Sameer Poyil

11:28 pm

Vendor - TEL - Sameer Poyil

Saturday 09 May
10:21 pm

Vendor - TEL - Sameer Poyil

LDT-4183 addressed code review comments

Options
    • -48
    • +61
    ./Controllers/DryBiCart.c
    • -1
    • +0
    ./Controllers/DryBiCart.h
Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Thursday 07 May
2:29 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review/vinay's comments

Options
    • -149
    • +94
    ./Controllers/BalancingChamber.c
    • -6
    • +5
    ./Modes/ModeGenDialysate.c
    • -1
    • +1
    ./Modes/ModeGenDialysate.h
Wednesday 06 May
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
1:41 pm

Vinayakam Mani

LDT-3958 heater control update

Options
    • -4
    • +4
    ./Controllers/BalancingChamber.c
    • -160
    • +122
    ./Controllers/Heaters.c
    • -2
    • +1
    ./Controllers/Heaters.h
    • -1
    • +5
    ./Controllers/Ultrafiltration.c
    • -2
    • +2
    ./DDCommon.h
    • -2
    • +0
    ./Modes/ModeGenDialysate.c
    • -0
    • +2
    ./Monitors/Conductivity.c
    • -1
    • +16
    ./Monitors/Temperature.c
12:50 pm

Vinayakam Mani

LDT-872 gain update

Options
    • -4
    • +4
    ./Controllers/Heaters.c
12:46 pm

Vinayakam Mani

LDT-872 fix

Options
    • -1
    • +2
    ./Services/Messaging.c
9:59 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -0
    • +1
    ./Modes/ModeGenDialysate.c
    • -9
    • +0
    ./Modes/ModeGenDialysate.h
    • -3
    • +6
    ./Services/TDInterface.c
9:39 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -5
    • +5
    ./Controllers/BalancingChamber.c
    • -19
    • +79
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Heaters.h
    • -0
    • +3
    ./DDCommon.h
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
    • -1
    • +16
    ./Monitors/Temperature.c
9:26 am

Michael Garthwaite

Merge branch 'staging' into LDT-3975-Boost-Pump

Options
    • -4
    • +4
    ./Modes/FPModes/ModePreGenPermeate.c
    • -5
    • +5
    ./Modes/FPModes/StateFlushConcentrate.c
    • -6
    • +5
    ./Modes/FPModes/StateFlushPermeate.c
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
7:41 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
7:40 am

Vendor - TEL - Jashwant Gantyada

7:39 am

Vendor - TEL - Sameer Poyil

LDT-4183 increasing max drybicart pressure to 20 PSI for beta 2.1

Options
    • -1
    • +1
    ./Controllers/DryBiCart.c
Tuesday 05 May
3:54 pm

Vinayakam Mani

3:17 pm

Vinayakam Mani

Use the get Acid mix control interval?

Use the get Acid mix control interval?

3:11 pm

Vinayakam Mani

Updates the comments for all new variables.

Updates the comments for all new variables.