Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3958 heater control update

LDT-872 heater control update

LDT-3958 heater control update

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LDT-4188 merge latest from staging

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LDT-4183 addressed code review comments

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

LDT-3963 addressed code review/vinay's comments

    • -149
    • +94
    ./Controllers/BalancingChamber.c
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LDT-3958 heater control update

LDT-872 gain update

LDT-872 fix

LDT-872 heater control update

LDT-872 heater control update

Merge branch 'staging' into LDT-3975-Boost-Pump

    • -5
    • +5
    ./Modes/FPModes/StateFlushConcentrate.c
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT-4183 increasing max drybicart pressure to 20 PSI for beta 2.1