Activity dd-firmware/firmware

9:24 am

Dara Navaei

More
300d460
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./App/DDCommon.h
- History
- Source
- Diff
./App/DDCommon.h

9:23 am

Vinayakam Mani

More
1eb5793
changed 2 files
develop

LDT-3597 resolving merge issues

- -2
- +2
./App/Controllers/BalancingChamber.c
- History
- Source
- Diff
./App/Controllers/BalancingChamber.c
- -0
- +1
./App/DDCommon.h
- History
- Source
- Diff
./App/DDCommon.h

9:15 am

Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Sameer Poyil

More
LEAHI-DD-FIRMWARE-LDT-3597-1
finished reviewing

9:09 am

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3597-1
added Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Sameer Poyil

9:02 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-4
commented on review

Use uppercase F

9:01 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-4
commented on review

Please declare local variables at top of scope (line 309 in this case).

7:53 am

The provided formula calculates electrolytic conductivity (k) by relating impedance measurements from a sensor to known calibration coefficients (B1,B2,B3) and an offset (B0). k: The calculated con...

The provided formula calculates electrolytic conductivity (k) by relating impedance measurements from a sensor to known calibration coefficients (B1,B2,B3) and an offset (B0).
k: The calculated conductivity.
impRz : The impedance of the solution, typically measured at a specific frequency (e.g., 100 kHz).
rtdRZ: The resistance of the Resistance Temperature Detector (RTD), used to perform temperature compensation.
B1,B2,B3, B0 : Empirical calibration coefficients specific to the sensor's geometry and electronic characteristics.

Linear Term (B3): Represents the primary relationship between conductance (1/impRZ) ) and conductivity. The factor of 1000 often scales the result into standard units like mS/cm or uS/cm

Temperature Compensation (B2 and B1): Since conductivity is highly temperature-dependent, these terms use rtdRZ
to adjust the calculation based on the actual temperature of the fluid. The logarithmic term (ln(rtdRz) accounts for non-linearities in the temperature response.

Offset (B0): Corrects for any residual signal or "zero-point" error in the measurement electronics.
.

7:43 am

Vendor - TEL - Sameer Poyil

at least mention what is the difference between the two apparoach?

7:42 am

Vendor - TEL - Sameer Poyil

There is no default case in that function switch ( sensorId ){ case P9_COND: sensorNum = TEENSY_SENSOR_0; break; case P18_COND: sensorNum = TEENSY_SENSOR_1; break; case D17_COND: sensorNum = TEENSY...

There is no default case in that function
switch ( sensorId )

Unknown macro: { case P9_COND}

7:38 am

Vendor - TEL - Sameer Poyil

typedef enum Conductivity_Models{ STANDARD, ///< standard equation for conductivity ALY_LINEAR, ///< Aly's high range model for conductivity UPDATED_STANDARD, ///< Updated stand equation with a lin...

typedef enum Conductivity_Models

Unknown macro: { STANDARD, ///< standard equation for conductivity ALY_LINEAR, ///< Aly's high range model for conductivity UPDATED_STANDARD, ///< Updated stand equation with a linear transformation. NUM_OF_MODELS, ///< Number of models used for conductivity calculation. }

COND_MODELS_T;

Its enumeration , if user send -1, -1 < NUM_OF_MODELS, this check passes

7:31 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3597-1
started review

LEAHI-DD-FIRMWARE-LDT-3597_(DD) D5 Heater not turning on on B2.0 HW

7:25 pm

Vinayakam Mani

More
5abf7ed
changed 1 file
LDT-2004-dialysate-composition-fix-merge--issue---dd, LDT-2004-v2-conductivity-sensors and 8 more LEAHI-DD-FIRMWARE-LDT-3597-1

LDT-3597 heater update

- -0
- +3
./App/Controllers/Heaters.c
- History
- Source
- Diff
./App/Controllers/Heaters.c

4:56 pm

Sean Nash

Since this driver is temporary, I don't think we need to document the approaches.

4:53 pm

Sean Nash

Doesn't look like this switch statement is doing anything. Can we remove it?

4:50 pm

Sean Nash

The Teensy driver is temporary - we will be deleting this driver in a few months. Let's just look for problems that might affect proper functionality.

4:00 pm