leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-1886 removed the pinch valves max value event. Added messages for the UI team

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Yes, I deleted.

Yes, I deleted.

Deleted.

Deleted.

Removed

Removed

Deleted.

Deleted.

LDT-473-treatment-parameters-create-rx--

Done

Done

Removed

Removed

Removed

Removed

Updated

Updated

Fixed

Fixed

Remove extra blank line.

Remove extra blank line.

MODE_TPAR should be deleted.

MODE_TPAR should be deleted.

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the ...

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the existing ID, ensure payload length is validated, and parse the param/value from the payload as expected.

Yes, this is called in OperationModes.c

Yes, this is called in OperationModes.c

Sure.

Sure.

Added.

Added.

Added.

Added.

This function has an output.

This function has an output.

Remove extra blank line.

Remove extra blank line.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

it can be directly initialized

it can be directly initialized

Done

Done

use the Rinse pump API to get the flow rate

use the Rinse pump API to get the flow rate

implement an API in RinsePump and call that API.

implement an API in RinsePump and call that API.