leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'LDT-2998-update-dialin-to-support-any-b1' into develop

Are we really allowed to skip pre-gen mode?

Are we really allowed to skip pre-gen mode?

It is speed as pulse width modulation.

It is speed as pulse width modulation.

D99 has been updated using the same approach applied to the D4 temperature.

D99 has been updated using the same approach applied to the D4 temperature.

Removed

Removed

Updated

Updated

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High)

This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High)

I think 50 samples is the max, so this is fine. Please remove the TODO comment.

I think 50 samples is the max, so this is fine. Please remove the TODO comment.

Added

Added

Changed

Changed

Added

Added

These overrides need to be updated to Leahi style (returns BOOL, takes message as param, is called by message handler, new Dialin message ID needed for override message, set/reset are merged into s...

These overrides need to be updated to Leahi style (returns BOOL, takes message as param, is called by message handler, new Dialin message ID needed for override message, set/reset are merged into single message handling function, etc...).

We do need to bring blood prime sub-mode into treatment mode (integrate). So signals that blood is primed and it's time to transition from blood prime to dialysis are needed. Treatment mode needs t...

We do need to bring blood prime sub-mode into treatment mode (integrate). So signals that blood is primed and it's time to transition from blood prime to dialysis are needed.
Treatment mode needs to be updated to include blood prime as a state (the first) in the treatment mode state machine and that state needs to call the exec function in this BloodPrime unit.

These are Denali valves. We need to set all Leahi TD actuators here as appropriate. This will eventually be specified by system arch document in JAMA if it's not already. If not yet, let's do the f...

These are Denali valves. We need to set all Leahi TD actuators here as appropriate. This will eventually be specified by system arch document in JAMA if it's not already. If not yet, let's do the following:
H1 valve = position B
H19 valve = position B
H4 (blood pump) = On (ramping to target rate)
H12/H13/H20 = Auto Air Trap Level Control (done with call to startAirTrapControl() function).
H10 = Off
H5 (ejector) = off (retracted)

Align comment with variable comments below.

Align comment with variable comments below.

I don't think we want this enum. There is already a VALVE_T in RotaryValve.h that lists the 2 pinch valves in TD. These are the 4 pinch valves in Denali HD.

I don't think we want this enum. There is already a VALVE_T in RotaryValve.h that lists the 2 pinch valves in TD. These are the 4 pinch valves in Denali HD.

Does this function return a speed or a pulse width?

Does this function return a speed or a pulse width?

These 2 functions seem redundant (with same prototypes above).

These 2 functions seem redundant (with same prototypes above).

Should be 2 blank lines before/after test support banner.

Should be 2 blank lines before/after test support banner.

Align comment.

Align comment.

Align comments. Also, generally, don't need () for atomic values.

Align comments. Also, generally, don't need () for atomic values.

.. function opens all of the balancing ...

.. function opens all of the balancing ...

Comment does not really help me understand what this is. Can we be a little more descriptive?

Comment does not really help me understand what this is. Can we be a little more descriptive?

Is this really a "test" function? It does not have the correct Dialin prototype (returns BOOL and takes a message as param) and it does not appear to handle a request from or respond to Dialin.

Is this really a "test" function? It does not have the correct Dialin prototype (returns BOOL and takes a message as param) and it does not appear to handle a request from or respond to Dialin.

Please introduce the test config for Beta1.9 changes across the files. This helps to continue work on Beta1.0 system without any issues.

Please introduce the test config for Beta1.9 changes across the files. This helps to continue work on Beta1.0 system without any issues.

Should be 2 blank lines before/after test support banner.

Should be 2 blank lines before/after test support banner.

Remove comment? Looks like we have an alarm.

Remove comment? Looks like we have an alarm.

Remove space(s) before }.

Remove space(s) before }.

Add blank line before separator.

Add blank line before separator.