leahi-common

Clone Tools

Stats

Commits this week: 13
Total Committers: 16
Last Commit: 18 Mar
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 08 Jan
3:00 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'LDT-2998-update-dialin-to-support-any-b1' into develop

Options
    • -6
    • +7
    /DDDefs.h
10:13 am

Sean Nash

Are we really allowed to skip pre-gen mode?

Are we really allowed to skip pre-gen mode?

10:00 am

Dara Navaei

It is speed as pulse width modulation.

It is speed as pulse width modulation.

Tuesday 06 Jan
1:15 pm

Vendor - TEL - Varshini Nagabooshanam

D99 has been updated using the same approach applied to the D4 temperature.

D99 has been updated using the same approach applied to the D4 temperature.

1:06 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:06 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:28 am

Dara Navaei

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

9:34 am

Zoltan Miskolci

This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High)

This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High)

9:14 am

Sean Nash

I think 50 samples is the max, so this is fine. Please remove the TODO comment.

I think 50 samples is the max, so this is fine. Please remove the TODO comment.

Monday 05 Jan
3:30 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Changed

Changed

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:56 pm

Sean Nash

These overrides need to be updated to Leahi style (returns BOOL, takes message as param, is called by message handler, new Dialin message ID needed for override message, set/reset are merged into s...

These overrides need to be updated to Leahi style (returns BOOL, takes message as param, is called by message handler, new Dialin message ID needed for override message, set/reset are merged into single message handling function, etc...).

2:53 pm

Sean Nash

We do need to bring blood prime sub-mode into treatment mode (integrate). So signals that blood is primed and it's time to transition from blood prime to dialysis are needed. Treatment mode needs t...

We do need to bring blood prime sub-mode into treatment mode (integrate). So signals that blood is primed and it's time to transition from blood prime to dialysis are needed.
Treatment mode needs to be updated to include blood prime as a state (the first) in the treatment mode state machine and that state needs to call the exec function in this BloodPrime unit.

2:49 pm

Sean Nash

These are Denali valves. We need to set all Leahi TD actuators here as appropriate. This will eventually be specified by system arch document in JAMA if it's not already. If not yet, let's do the f...

These are Denali valves. We need to set all Leahi TD actuators here as appropriate. This will eventually be specified by system arch document in JAMA if it's not already. If not yet, let's do the following:
H1 valve = position B
H19 valve = position B
H4 (blood pump) = On (ramping to target rate)
H12/H13/H20 = Auto Air Trap Level Control (done with call to startAirTrapControl() function).
H10 = Off
H5 (ejector) = off (retracted)

11:33 am

Sean Nash

Align comment with variable comments below.

Align comment with variable comments below.

11:31 am

Sean Nash

I don't think we want this enum. There is already a VALVE_T in RotaryValve.h that lists the 2 pinch valves in TD. These are the 4 pinch valves in Denali HD.

I don't think we want this enum. There is already a VALVE_T in RotaryValve.h that lists the 2 pinch valves in TD. These are the 4 pinch valves in Denali HD.

10:56 am

Sean Nash

Does this function return a speed or a pulse width?

Does this function return a speed or a pulse width?

10:54 am

Sean Nash

These 2 functions seem redundant (with same prototypes above).

These 2 functions seem redundant (with same prototypes above).

10:48 am

Sean Nash

Should be 2 blank lines before/after test support banner.

Should be 2 blank lines before/after test support banner.

10:43 am

Sean Nash

Align comment.

Align comment.

10:41 am

Sean Nash

Align comments. Also, generally, don't need () for atomic values.

Align comments. Also, generally, don't need () for atomic values.

10:37 am

Sean Nash

.. function opens all of the balancing ...

.. function opens all of the balancing ...

10:36 am

Sean Nash

Comment does not really help me understand what this is. Can we be a little more descriptive?

Comment does not really help me understand what this is. Can we be a little more descriptive?

10:33 am

Sean Nash

Is this really a "test" function? It does not have the correct Dialin prototype (returns BOOL and takes a message as param) and it does not appear to handle a request from or respond to Dialin.

Is this really a "test" function? It does not have the correct Dialin prototype (returns BOOL and takes a message as param) and it does not appear to handle a request from or respond to Dialin.

10:33 am

Vinayakam Mani

Please introduce the test config for Beta1.9 changes across the files. This helps to continue work on Beta1.0 system without any issues.

Please introduce the test config for Beta1.9 changes across the files. This helps to continue work on Beta1.0 system without any issues.

10:30 am

Sean Nash

Should be 2 blank lines before/after test support banner.

Should be 2 blank lines before/after test support banner.

10:29 am

Sean Nash

Remove comment? Looks like we have an alarm.

Remove comment? Looks like we have an alarm.

10:28 am

Sean Nash

Remove space(s) before }.

Remove space(s) before }.

10:26 am

Sean Nash

Add blank line before separator.

Add blank line before separator.