leahi-common

Clone Tools

Stats

Commits this week: 31
Total Committers: 18
Last Commit: 16:36
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Jan
2:32 pm

Vendor - TEL - Varshini Nagabooshanam

Merge LDT-473-treatment-parameters-create-rx--

Options
    • -6
    • +6
    /AlarmDefs.h
    • -0
    • +1
    /TDDefs.h
1:57 pm

Sean Nash

Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE.

Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE.

1:56 pm

Sean Nash

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Sinc...

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Since we don't have a STABILIZATION_2 state, we would need to jump back to STABILIZATION state instead.

1:52 pm

Sean Nash

Fix indent on this case.

Fix indent on this case.

1:52 pm

Sean Nash

Why are we keeping any code where the STABILIZATION_2 state used to be? Shouldn't the entire case be deleted?

Why are we keeping any code where the STABILIZATION_2 state used to be? Shouldn't the entire case be deleted?

1:50 pm

Sean Nash

We need to set the current state to PRESSURE_LIMITS_STATE_STABLE here I think. Otherwise, how will we get to stable state?

We need to set the current state to PRESSURE_LIMITS_STATE_STABLE here I think. Otherwise, how will we get to stable state?

1:48 pm

Sean Nash

Can we do the separate outer bounds inside the setPressureLimitsToOuterBounds() function?

Can we do the separate outer bounds inside the setPressureLimitsToOuterBounds() function?

1:32 pm

Sean Nash

Why do I not see a similar variable for arterial and venous pressures?

Why do I not see a similar variable for arterial and venous pressures?

1:31 pm

Sean Nash

When comment is too far to right to align with other comments, use the following comment format: <blank line> /// comment... #define ... <blank line>

When comment is too far to right to align with other comments, use the following comment format:
<blank line>
/// comment...
#define ...
<blank line>

1:30 pm

Sean Nash

Missing comment to right

Missing comment to right

1:29 pm

Sean Nash

Does ModeTxParams.h exist? Didn't we change this to a service?

Does ModeTxParams.h exist? Didn't we change this to a service?

1:27 pm

Sean Nash

TxLog property should be TRUE. NoDRcr property is FALSE in arterial/venous alarms - is there a reason why TMP is different? Priority should be HIGH. Rank should be somewhere around 200 (see if PRS ...

TxLog property should be TRUE.
NoDRcr property is FALSE in arterial/venous alarms - is there a reason why TMP is different?
Priority should be HIGH.
Rank should be somewhere around 200 (see if PRS specifies or ask Eliza what it should be).

1:24 pm

Sean Nash

Add the word "pressure" after TMP in comments.

Add the word "pressure" after TMP in comments.

12:22 pm

Michael Garthwaite

12:04 pm

Michael Garthwaite

updated to consider the build switch.

updated to consider the build switch.

12:04 pm

Michael Garthwaite

yes. they are added.

yes. they are added.

12:02 pm

Michael Garthwaite

fixed.

fixed.

12:01 pm

Michael Garthwaite

fixed.

fixed.

12:01 pm

Michael Garthwaite

removed.

removed.

12:00 pm

Michael Garthwaite

correct. It has been updated to call around based the build switch

correct. It has been updated to call around based the build switch

11:59 am

Michael Garthwaite

removed from here.

removed from here.

11:59 am

Michael Garthwaite

teensy wants to parse commands with a , when it has parameters. Lots of string searching with length(), startsWith(), readStringUntil(), and indexOf(). We needed to keep it a char array sowe dont h...

teensy wants to parse commands with a , when it has parameters. Lots of string searching with length(), startsWith(), readStringUntil(), and indexOf(). We needed to keep it a char array sowe dont have to refactor the command handler in teensy.

11:52 am

Michael Garthwaite

see previous comment.

see previous comment.

11:52 am

Michael Garthwaite

see previous comment.

see previous comment.

11:50 am

Michael Garthwaite

Teensy will want to parse the commands as a string when it has >1 parameters in the command. Not every command has a parameter with it. it is copied over to condWriteCmdBuffer once we get the lengt...

Teensy will want to parse the commands as a string when it has >1 parameters in the command. Not every command has a parameter with it. it is copied over to condWriteCmdBuffer once we get the length from snprint()

11:44 am

Michael Garthwaite

fixed spelling

fixed spelling

11:44 am

Michael Garthwaite

fixed.

fixed.

11:42 am

Michael Garthwaite

fixed.

fixed.

11:34 am

Michael Garthwaite

coefficient data has been updated and commented.

coefficient data has been updated and commented.

11:33 am

Michael Garthwaite

removed.

removed.