leahi-common

Clone Tools

Stats

Commits this week: 11
Total Committers: 16
Last Commit: 18 Mar
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 27 Jan
9:47 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2998 merge latest into staging

Options
9:38 am

Michael Garthwaite

for Teensy it is done at the driver as it is a part of the initialization sequence. See TEENSY_CMD_GET_EEPROM_DATA cmd.

for Teensy it is done at the driver as it is a part of the initialization sequence. See TEENSY_CMD_GET_EEPROM_DATA cmd.

9:30 am

Michael Garthwaite

Not at the moment. This feature isnt expected to on the V2's. The v2's arent going to have ALY_LINEAR as that is one specific to the teensy sensors.

Not at the moment. This feature isnt expected to on the V2's. The v2's arent going to have ALY_LINEAR as that is one specific to the teensy sensors.

8:54 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2998 merge latest from staging

Options
Monday 26 Jan
10:31 pm

Sean Nash

#ifdef TEENSY for these new functions.

#ifdef TEENSY for these new functions.

10:31 pm

Sean Nash

Only needed for TEENSY, right? So #ifdef should be applied.

Only needed for TEENSY, right? So #ifdef should be applied.

10:30 pm

Sean Nash

No model selection for V2 sensor?

No model selection for V2 sensor?

10:29 pm

Sean Nash

Teensy driver doesn't need overrides too?

Teensy driver doesn't need overrides too?

10:27 pm

Sean Nash

Probably shouldn't have "TEENSY" in the name. Non-teensy driver will probably need this too, so can be generic.

Probably shouldn't have "TEENSY" in the name. Non-teensy driver will probably need this too, so can be generic.

10:25 pm

Sean Nash

Is calibration going to be done here or at driver? I was expecting driver to calibrate since cal factors are coming from sensor.

Is calibration going to be done here or at driver? I was expecting driver to calibrate since cal factors are coming from sensor.

10:23 pm

Sean Nash

Remove blank line.

Remove blank line.

10:22 pm

Sean Nash

Should we have #ifdef here to determine which driver to initialize?

Should we have #ifdef here to determine which driver to initialize?

10:20 pm

Sean Nash

If we're not using filtered values, why filter them at all?

If we're not using filtered values, why filter them at all?

10:15 pm

Sean Nash

Add comments to right.

Add comments to right.

10:13 pm

Sean Nash

enum should have a /// comment on top.

enum should have a /// comment on top.

10:12 pm

Sean Nash

Shouldn't D27 temp be gotten from monitor (Temperature.c) instead of from conductivity drivers?

Shouldn't D27 temp be gotten from monitor (Temperature.c) instead of from conductivity drivers?

3:57 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /AlarmDefs.h
    • -2
    • +2
    /TDDefs.h
2:32 pm

Vendor - TEL - Varshini Nagabooshanam

Merge LDT-473-treatment-parameters-create-rx--

Options
    • -6
    • +6
    /AlarmDefs.h
    • -0
    • +1
    /TDDefs.h
1:57 pm

Sean Nash

Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE.

Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE.

1:56 pm

Sean Nash

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Sinc...

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Since we don't have a STABILIZATION_2 state, we would need to jump back to STABILIZATION state instead.

1:52 pm

Sean Nash

Fix indent on this case.

Fix indent on this case.

1:52 pm

Sean Nash

Why are we keeping any code where the STABILIZATION_2 state used to be? Shouldn't the entire case be deleted?

Why are we keeping any code where the STABILIZATION_2 state used to be? Shouldn't the entire case be deleted?

1:50 pm

Sean Nash

We need to set the current state to PRESSURE_LIMITS_STATE_STABLE here I think. Otherwise, how will we get to stable state?

We need to set the current state to PRESSURE_LIMITS_STATE_STABLE here I think. Otherwise, how will we get to stable state?

1:48 pm

Sean Nash

Can we do the separate outer bounds inside the setPressureLimitsToOuterBounds() function?

Can we do the separate outer bounds inside the setPressureLimitsToOuterBounds() function?

1:32 pm

Sean Nash

Why do I not see a similar variable for arterial and venous pressures?

Why do I not see a similar variable for arterial and venous pressures?

1:31 pm

Sean Nash

When comment is too far to right to align with other comments, use the following comment format: <blank line> /// comment... #define ... <blank line>

When comment is too far to right to align with other comments, use the following comment format:
<blank line>
/// comment...
#define ...
<blank line>

1:30 pm

Sean Nash

Missing comment to right

Missing comment to right

1:29 pm

Sean Nash

Does ModeTxParams.h exist? Didn't we change this to a service?

Does ModeTxParams.h exist? Didn't we change this to a service?

1:27 pm

Sean Nash

TxLog property should be TRUE. NoDRcr property is FALSE in arterial/venous alarms - is there a reason why TMP is different? Priority should be HIGH. Rank should be somewhere around 200 (see if PRS ...

TxLog property should be TRUE.
NoDRcr property is FALSE in arterial/venous alarms - is there a reason why TMP is different?
Priority should be HIGH.
Rank should be somewhere around 200 (see if PRS specifies or ask Eliza what it should be).

1:24 pm

Sean Nash

Add the word "pressure" after TMP in comments.

Add the word "pressure" after TMP in comments.