leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-1415 added a comment in the DD valves enum

Merge LDT-1415-pressures-monitoring-td

Updated

Updated

Updated

Updated

Format for params is: param name description Add "psi" (name) between param and "Pressure value in PSI".

Format for params is: param name description
Add "psi" (name) between param and "Pressure value in PSI".

I removed

I removed

Sorry, updated

Sorry, updated

done.

done.

Please keep local declarations together up top.

Please keep local declarations together up top.

removed.

removed.

done.

done.

Updated

Updated

Updated

Updated

LDT-1415-pressures-monitoring-td

Add space between = and (F32)

Add space between = and (F32)

Yes we need to add

Yes we need to add

Added param looks wrong.

Added param looks wrong.

Align | separators all the way to right end of these 2 rows.

Align | separators all the way to right end of these 2 rows.

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function. I think we want to avoid complex logic or function calls as a function para...

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function.
I think we want to avoid complex logic or function calls as a function parameter per our coding standards.

Remove blank line.

Remove blank line.

No, by mistake I copy pasted the same

No, by mistake I copy pasted the same

Added

Added

Added

Added

Updated

Updated

Updated

Updated

done.

done.

Updated

Updated

Sorry, Updated

Sorry, Updated

done.

done.