leahi-common

Clone Tools

Stats

Commits this week: 21
Total Committers: 17
Last Commit: 16:07
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Feb
12:14 pm

Michael Garthwaite

WIP on develop

LDT-3372: updated IOFP msg id list as it was out of sync.

Options
    • -20
    • +20
    /MsgDefs.h
12:10 pm

Sean Nash

12:04 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
11:44 am

Vendor - TEL - Sameer Poyil

LDT-2004-3 Merging branch staging into LDT-2004-drybicarb---dd

Options
    • -2
    • +2
    /DDDefs.h
    • -2
    • +13
    /MsgDefs.h
10:50 am

Sean Nash

Add TODO to comment.

Add TODO to comment.

10:48 am

Sean Nash

Put () around the 2 conditions

Put () around the 2 conditions

10:03 am

Sean Nash

Does it make more sense to have them together?

Does it make more sense to have them together?

10:01 am

Sean Nash

Is there no "first" enum for this group?

Is there no "first" enum for this group?

10:00 am

Sean Nash

Align comment.

Align comment.

9:30 am

Vendor - TEL - Jashwant Gantyada

removed.

removed.

9:30 am

Vendor - TEL - Jashwant Gantyada

updated.

updated.

9:30 am

Vendor - TEL - Jashwant Gantyada

done

done

9:29 am

Vendor - TEL - Jashwant Gantyada

removed.

removed.

7:24 am

Raghu Kallala

Resolved

Resolved

7:22 am

Raghu Kallala

Updated

Updated

7:21 am

Raghu Kallala

Updated

Updated

Monday 09 Feb
7:22 pm

Vendor - TEL - Sameer Poyil

arrange this code and new sensor code in a group- line 131 - 142

arrange this code and new sensor code in a group- line 131 - 142

7:19 pm

Vendor - TEL - Sameer Poyil

I think we need a #ifdef TEENSY macro ?

I think we need a #ifdef TEENSY macro ?

7:16 pm

Vendor - TEL - Sameer Poyil

Need two spaces before the test function

Need two spaces before the test function

4:22 pm

Vendor - TEL - Jashwant Gantyada

This is from latest staging changes.

This is from latest staging changes.

2:03 pm

Sean Nash

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

2:01 pm

Sean Nash

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

1:59 pm

Sean Nash

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

1:58 pm

Sean Nash

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

1:12 pm

Sean Nash

Align comments.

Align comments.

1:11 pm

Sean Nash

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

1:09 pm

Sean Nash

Add space between } and type name.

Add space between } and type name.

1:08 pm

Sean Nash

Indenting looks off for most fields in this struct.

Indenting looks off for most fields in this struct.

1:07 pm

Sean Nash

Why doesn't name and comment match?

Why doesn't name and comment match?

10:44 am

Michael Garthwaite

WIP on develop

Options
    • -1
    • +7
    /MsgDefs.h