leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Use #define macros for magic numbers.

Use #define macros for magic numbers.

It was typo. Updated it.

It was typo. Updated it.

This doesn't look right. Status = time?

This doesn't look right. Status = time?

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Remove extra blank line.

Remove extra blank line.

Add a TODO to comment then.

Add a TODO to comment then.

updated.

updated.

updated.

updated.

updated.

updated.

done

done

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

done.

done.

done.

done.

done.

done.

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation
In °C?

In °C?

Is return value in °C? U32 is pretty low resolution for a temperature.

Is return value in °C? U32 is pretty low resolution for a temperature.

Remove the empty space.

Remove the empty space.

Can we remove this #if check? we can keep the comment.

Can we remove this #if check? we can keep the comment.

can we get each group of level check in to a function and call those functions for each case?

can we get each group of level check in to a function and call those functions for each case?

LEAHI-APPLICATION-LDT-3373_Misc SW Enhancements - SW - 01 - BloodPrime-02 - R&I
LEAHI-APPLICATION-LDT-3373_Misc SW Enhancements - SW - 01 - BloodPrime-02 - R&I
changed.

changed.

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?