leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3539-air-infusion-td

There is a standardized level checking logic proposed , please check with Noe

There is a standardized level checking logic proposed , please check with Noe

please use FPGA version function to initialize or handle HW version

please use FPGA version function to initialize or handle HW version

read the FPGA ID and initialize it

read the FPGA ID and initialize it

remove #if 1 and add a TODO with this comment

remove #if 1 and add a TODO with this comment

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

Had that question. Thanks Changed to else block

Had that question. Thanks
Changed to else block

Updated

Updated

This will be gone once we have institutional records, do you still want me to move it to a separate func?

This will be gone once we have institutional records, do you still want me to move it to a separate func?

Fixed

Fixed

Can we uncomment these and send msg?

Can we uncomment these and send msg?

Can we uncomment this and send the limits to the UI?

Can we uncomment this and send the limits to the UI?

Should we cast these to (S32)?

Should we cast these to (S32)?

These 2 last values have already been used above. Change to 154 and 155.

These 2 last values have already been used above. Change to 154 and 155.

Can this stuff down here be done in a separate function that is called here? This function is too big.

Can this stuff down here be done in a separate function that is called here? This function is too big.

Should this just be an "else" to above condition?

Should this just be an "else" to above condition?

When do you plan on removing this?

When do you plan on removing this?

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command m...

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command message handlers like these.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

We will not have this saline bolus state in Leahi.

We will not have this saline bolus state in Leahi.

This alarm does not belong here. Put it back where it was before. In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

This alarm does not belong here. Put it back where it was before.
In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Only 1 return per function.

Only 1 return per function.

If result is U08, why are we returning U16?

If result is U08, why are we returning U16?

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Only 1 return statement per function.

Only 1 return statement per function.

Fix alignment of all of the | separators.

Fix alignment of all of the | separators.

This table should be sorted, so this row needs to be moved up now.

This table should be sorted, so this row needs to be moved up now.

Fix alignment.

Fix alignment.

Why remove these functions. All static functions should be prototyped up here.

Why remove these functions. All static functions should be prototyped up here.