leahi-common

Clone Tools

Stats

Commits this week: 20
Total Committers: 20
Last Commit: 14:02
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Mar
2:16 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /TDDefs.h
2:11 pm

Sean Nash

This should be invalid state (or something like that).

This should be invalid state (or something like that).

2:11 pm

Sean Nash

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

2:08 pm

Sean Nash

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

2:07 pm

Sean Nash

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

10:59 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:54 am

Behrouz NematiPour

Merge branch 'feature/LDT-3373-misc-sw-enhancements-bloodprime' into staging

Options
Monday 02 Mar
9:01 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /AlarmDefs.h
8:52 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-1903-air-trap-level-control---td---0 into staging

Options
8:46 pm

Sean Nash

8:45 pm

Vendor - TEL - Sameer Poyil

Merge branch 'staging' into LDT-1903-air-trap-level-control---td---0

Options
    • -6
    • +6
    /AlarmDefs.h
4:41 pm

Sean Nash

Still need to range check the rate, reject if out of range, accept and assign if in range.

Still need to range check the rate, reject if out of range, accept and assign if in range.

4:26 pm

Sean Nash

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

3:12 pm

Michael Garthwaite

LDT-2004: moved conductivity sensor enum to dd defs so both drivers can use it. Removed ifdef for teensy in relation to its overrides.

Options
    • -1
    • +18
    /DDDefs.h
    • -8
    • +3
    /MsgDefs.h
3:12 pm

Michael Garthwaite

LDT-2004: moved conductivity sensor enum to dd defs so both drivers can use it. Removed ifdef for teensy in relation to its overrides.

Options
    • -1
    • +18
    /DDDefs.h
    • -8
    • +3
    /MsgDefs.h
2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Assigned to local variable

Assigned to local variable

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Updated to else part

Updated to else part

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

2:51 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:13 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:58 pm

Sean Nash

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

1:32 pm

Vendor - TEL - Jashwant Gantyada

handled accordingly.

handled accordingly.

1:32 pm

Vendor - TEL - Jashwant Gantyada

removed and added.

removed and added.

11:54 am

Vendor - TEL - Sameer Poyil

fixed in latest code

fixed in latest code

11:53 am

Vendor - TEL - Sameer Poyil

implemented

implemented

11:53 am

Vendor - TEL - Sameer Poyil

fixed

fixed

11:39 am

Vendor - TEL - Sameer Poyil

LDT-1903 removing ALARM_ID_TD_AIR_PUMP_DUTY_CYCLE_OUT_OF_RANGE

Options
    • -4
    • +4
    /AlarmDefs.h
11:16 am

Sean Nash

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

11:11 am

Vendor - TEL - Sameer Poyil

LDT-1903 Adding Air pump duty cycle out of range alarm

Options
    • -4
    • +4
    /AlarmDefs.h