leahi-common

Clone Tools

Stats

Commits this week: 22
Total Committers: 18
Last Commit: 07 May
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 07 May
10:20 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -1
    • +1
    /TDDefs.h
9:32 am

Vendor - TEL - Varshini Nagabooshanam

9:31 am

Vendor - TEL - Jashwant Gantyada and Sean Nash

9:31 am

Vendor - TEL - Jashwant Gantyada

Wednesday 06 May
5:55 pm

Sean Nash

Same comment as duration confirmation. compare uf rate too.

Same comment as duration confirmation. compare uf rate too.

5:44 pm

Sean Nash

Also check uf rate from confirmation message (request) is still the same as validated uf rate. WARNING - uf rate will be a float and we shouldn't use == operator on floats.

Also check uf rate from confirmation message (request) is still the same as validated uf rate.
WARNING - uf rate will be a float and we shouldn't use == operator on floats.

5:38 pm

Sean Nash

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

5:38 pm

Sean Nash

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

1:58 pm

Sean Nash

11:43 am

Sean Nash

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

10:26 am

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-common into LDT-2240-disposable-tube-set-self-test

Options
    • -1
    • +1
    /MsgDefs.h
10:23 am

Vendor - TEL - Varshini Nagabooshanam

LDT-3910-request-add-td-config-flag-so

Options
    • -3
    • +3
    /AlarmDefs.h
10:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
LEAHI-DD-FIRMWARE-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
Tuesday 05 May
6:54 pm

Sean Nash

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

6:52 pm

Sean Nash

2 lines above/below banner

2 lines above/below banner

6:48 pm

Sean Nash

remove blank line.

remove blank line.

6:25 pm

Sean Nash

use response.x for these.

use response.x for these.

6:25 pm

Sean Nash

use response.duration.

use response.duration.

6:24 pm

Sean Nash

Already set this above.

Already set this above.

4:36 pm

Vendor - TEL - Praneeth Bunne

LDT-1886: Addressed code review comments

Options
    • -2
    • +2
    /TDDefs.h
3:58 pm

Sean Nash

no need to respond.

no need to respond.

3:58 pm

Sean Nash

don't need response to a response.

don't need response to a response.

3:54 pm

Sean Nash

don't need this if statement either and don't need what's inside the if.

don't need this if statement either and don't need what's inside the if.

3:49 pm

Sean Nash

Don't need this if statement or flag.

Don't need this if statement or flag.

3:46 pm

Sean Nash

use separate time than stability (even if same right now).

use separate time than stability (even if same right now).

3:42 pm

Sean Nash

Move to transition function and remove this if statement.

Move to transition function and remove this if statement.

3:40 pm

Sean Nash

do 2 data with the p1 and p2 pressures.

do 2 data with the p1 and p2 pressures.

3:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

3:35 pm

Sean Nash

Remove if statement. Always set valve to pos A.

Remove if statement. Always set valve to pos A.

3:32 pm

Sean Nash

Want to stop air pump, not end air trap control.

Want to stop air pump, not end air trap control.