leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT 1886: Removed unnecessary code

LDT-1886: Resolve merge conflicts

LDT-1886: Resolve merge conflicts

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

This merge conflict is still unresolved.

This merge conflict is still unresolved.

leak in the comment section.

leak in the comment section.

Where is alarm 191..203?

Where is alarm 191..203?

LDT-1886: Resolve merge conflicts

Align comment.

Align comment.

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

Should this line be un-commented?

Should this line be un-commented?

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

Rename similar to ADDR definitions below. these are not commands.

Rename similar to ADDR definitions below. these are not commands.

Combine charger and pack data into one payload with one broadcast message.

Combine charger and pack data into one payload with one broadcast message.

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

I think we only need one data message for both charger and battery pack data.

I think we only need one data message for both charger and battery pack data.

Remove.

Remove.

uncomment.

uncomment.

LDT-4072: Fix battery alarm priority rank and add message IDs

LDT-3505: Updated force sensor calibration message id

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

Now it's backward. You have to change the ENABLE to DISABLE too.

Now it's backward. You have to change the ENABLE to DISABLE too.