leahi-common

Clone Tools

Stats

Commits this week: 20
Total Committers: 19
Last Commit: 16:30
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 May
12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement

11:35 am

Sean Nash

remove comma

remove comma

11:24 am

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

11:20 am

Sean Nash

Move up with rest

Move up with rest

11:17 am

Sean Nash

Move this function to your service.

Move this function to your service.

11:09 am

Sean Nash

Not needed.

Not needed.

11:06 am

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

11:01 am

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

10:03 am

Sean Nash

slaveAddr should be an enum now and so just "device".

slaveAddr should be an enum now and so just "device".

9:07 am

Sean Nash

Add a banner before Dialin test support functions (see other units for example).

Add a banner before Dialin test support functions (see other units for example).

9:04 am

Sean Nash

Initialize .override to OVERRIDE_RESET

Initialize .override to OVERRIDE_RESET

9:03 am

Sean Nash

Why is this commented out? Do we not need to initialize it?

Why is this commented out? Do we not need to initialize it?

Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

leak in the comment section.

leak in the comment section.

3:34 pm

Sean Nash

Where is alarm 191..203?

Where is alarm 191..203?

2:33 pm

Sean Nash

2:30 pm

Sean Nash

Align comment.

Align comment.

2:24 pm

Sean Nash

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

2:20 pm

Sean Nash

Should this line be un-commented?

Should this line be un-commented?

2:19 pm

Sean Nash

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

2:16 pm

Sean Nash

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

9:27 am

Sean Nash

Rename similar to ADDR definitions below. these are not commands.

Rename similar to ADDR definitions below. these are not commands.