Activity leahi-common/

Tree
Accordion

Stats

Commits this week: 32

Total Committers:	19
Last Commit:	26 May
Commits this week:	32

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 26 May

2:59 pm

Dara Navaei

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

2:56 pm

Dara Navaei

These are located in the integrity.c

These are located in the integrity.c

2:55 pm

Dara Navaei

Yes the ECC checks are done in the bootloader stack.

Yes the ECC checks are done in the bootloader stack.

11:30 am

Raghu Kallala

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

11:15 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

11:14 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

11:10 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

11:09 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

11:07 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

please align the comments

please align the comments

10:36 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

10:34 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines and check other functions too.

Please break it into two lines and check other functions too.

10:34 am

Vendor - TEL - Varshini Nagabooshanam

10:30 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines

Please break it into two lines

10:30 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines

Please break it into two lines

10:27 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

10:22 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines

Please break it into two lines

10:21 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please break it into two lines

Please break it into two lines

10:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

TREAT_PARAMS_PROPERTIES should also be an input?

TREAT_PARAMS_PROPERTIES should also be an input?

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

please add @param

please add @param

10:05 am

Zoltan Miskolci

More
Re: LEAHI-TD-FIRMWARE-LDT-2240-1
commented on review

Shouldn't this file contain the incoming request and associate it to the corresponding function? And that function will trigger the response sending part. Declaring the response here instead seems...

Shouldn't this file contain the incoming request and associate it to the corresponding function?
And that function will trigger the response sending part.

Declaring the response here instead seems out of regular design scheme.

10:04 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

please align the comment

please align the comment

Friday 22 May

3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-1886-2
finished reviewing

1:14 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:22 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-3215-1
resumed reviewing

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

12:03 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-05-27 01:18 -0700