leahi-common

Clone Tools

Stats

Commits this week: 32
Total Committers: 19
Last Commit: 26 May
Commits this week: 32

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 26 May
5:37 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -2
    • +1
    /AlarmDefs.h
2:59 pm

Dara Navaei

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

2:56 pm

Dara Navaei

These are located in the integrity.c

These are located in the integrity.c

2:55 pm

Dara Navaei

Yes the ECC checks are done in the bootloader stack.

Yes the ECC checks are done in the bootloader stack.

2:00 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Options
    • -67
    • +35
    /AlarmDefs.h
11:30 am

Raghu Kallala

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

11:15 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

11:14 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

11:10 am

Vendor - TEL - Arpita Srivastava

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

11:09 am

Vendor - TEL - Arpita Srivastava

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

11:07 am

Vendor - TEL - Arpita Srivastava

please align the comments

please align the comments

10:36 am

Vendor - TEL - Arpita Srivastava

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

10:34 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines and check other functions too.

Please break it into two lines and check other functions too.

10:34 am

Vendor - TEL - Varshini Nagabooshanam

10:33 am

Vendor - TEL - Varshini Nagabooshanam

Fixed

Options
    • -49
    • +69
    /AlarmDefs.h
    • -11
    • +10
    /TDDefs.h
10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:30 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:27 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

10:22 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:21 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:15 am

Vendor - TEL - Arpita Srivastava

Please break it into two lines

Please break it into two lines

10:13 am

Vendor - TEL - Arpita Srivastava

TREAT_PARAMS_PROPERTIES should also be an input?

TREAT_PARAMS_PROPERTIES should also be an input?

10:05 am

Vendor - TEL - Arpita Srivastava

please add @param

please add @param

10:05 am

Zoltan Miskolci

Shouldn't this file contain the incoming request and associate it to the corresponding function? And that function will trigger the response sending part. Declaring the response here instead seems...

Shouldn't this file contain the incoming request and associate it to the corresponding function?
And that function will trigger the response sending part.

Declaring the response here instead seems out of regular design scheme.

10:04 am

Vendor - TEL - Arpita Srivastava

please align the comment

please align the comment

Saturday 23 May
8:58 pm

Vendor - TEL - Vijay Pamula

LDT-3970 Merge latest from staging

Options
    • -2
    • +2
    /MsgDefs.h
    • -6
    • +7
    /TDDefs.h
Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

2:50 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /AlarmDefs.h
2:48 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Options
    • -1
    • +5
    /AlarmDefs.h