leahi-common

Clone Tools

Stats

Commits this week: 19
Total Committers: 19
Last Commit: 18:16
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
7 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-4009 addressed code review comments

Options
    • -1
    • +1
    /TDDefs.h
7 hrs ago

Vinayakam Mani

Could you update the Message ID to latest? 0XA9 is already used.

Could you update the Message ID to latest? 0XA9 is already used.

8 hrs ago

Sean Nash

Align comment.

Align comment.

8 hrs ago

Vendor - TEL - Jashwant Gantyada

where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

8 hrs ago

Vendor - TEL - Jashwant Gantyada

do we need this block?

do we need this block?

9 hrs ago

Vinayakam Mani

update the comment as required: ml or L?

update the comment as required: ml or L?

9 hrs ago

Sean Nash

9 hrs ago

Sean Nash

9 hrs ago

Sean Nash

Friday 29 May
6:29 pm

Vinayakam Mani

6:29 pm

Vinayakam Mani

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

6:25 pm

Vinayakam Mani

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

6:20 pm

Vinayakam Mani

Substitution pump

Substitution pump

3:57 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
    • -2
    • +2
    /TDDefs.h
2:57 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:33 pm

Vendor - TEL - Arpita Srivastava

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

2:03 pm

Vinayakam Mani

Missing comment.

Missing comment.

2:01 pm

Vinayakam Mani

update comment. next one as well.

update comment. next one as well.

2:00 pm

Vinayakam Mani

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

12:01 pm

Dara Navaei

LEAHI-COMMON-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-COMMON-LDT-4000_HDF - FW Implementation - 1/4:
11:47 am

Michael Garthwaite

LDT-4001: updates to msg ids'

Options
    • -1
    • +2
    /MsgDefs.h
11:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
10:10 am

Michael Garthwaite

LDT-4000: substitution pump override ids. floater level override request.

Options
    • -0
    • +3
    /MsgDefs.h
9:56 am

Sean Nash

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

9:52 am

Sean Nash

else reason is Invalid Request Format

else reason is Invalid Request Format

9:47 am

Sean Nash

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume. I don't know if there is a mini...

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume.
I don't know if there is a minimum iso UF volume.

9:45 am

Sean Nash

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso ...

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso UF instead of how much time we've spent in the HD or HDF treatment.

9:40 am

Sean Nash

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration. And I'm not sure if there is a minimum duration for iso uf, but if there is a m...

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration.
And I'm not sure if there is a minimum duration for iso uf, but if there is a minimum, it probably isn't the same as the minimum treatment duration.

9:37 am

Sean Nash

Just add this as an AND condition in the if statement above.

Just add this as an AND condition in the if statement above.