leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3735: Pulled staging

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Why is this on a separate line? Move after = above.

Why is this on a separate line? Move after = above.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
LDT-4031: Update Pre-treatment patient connection state

LDT-5157: Added alarm ids for instit basic, advanced and additional

This was added by Vinay to force the chamber F filling.

This was added by Vinay to force the chamber F filling.

It was changed by Vinay as part of the Conductivity spikes issue.

It was changed by Vinay as part of the Conductivity spikes issue.

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

bicarbChamberLevel is a local variable and not an input

bicarbChamberLevel is a local variable and not an input

This is not required , we should design the state machine properly to handle chamber low level

This is not required , we should design the state machine properly to handle chamber low level

This is not the correct order for state machine,

This is not the correct order for state machine,

LDT-4063: Resolved conflicts

LDT:4072 - Resolved conflicts

Can't return in middle of function code.

Can't return in middle of function code.

Remove else and reject command in it and re-test.

Remove else and reject command in it and re-test.

LDT-5157: Added alram id for conductivity calibration

LDT-4611: created alarm dialysate proportioning in progress alarm.

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?