leahi-common

Clone Tools

Stats

Commits this week: 31
Total Committers: 19
Last Commit: 28 Jul
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Jul
4:13 pm

Sean Nash

Remove leading space before void.

Remove leading space before void.

4:13 pm

Sean Nash

Is issue resolved? Can we revert now?

Is issue resolved? Can we revert now?

4:12 pm

Sean Nash

Also an input I think.

Also an input I think.

4:08 pm

Sean Nash

3:58 pm

Sean Nash

keep a blank line between declaration(s) and code.

keep a blank line between declaration(s) and code.

3:57 pm

Sean Nash

If level can be overridden, you should use get function.

If level can be overridden, you should use get function.

3:55 pm

Sean Nash

Add blank line before banner.

Add blank line before banner.

3:20 pm

Vinayakam Mani

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

3:15 pm

Vinayakam Mani

That's the worst-case timeout decided by team.

That's the worst-case timeout decided by team.

11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

10:26 am

Sean Nash

Why is this on a separate line? Move after = above.

Why is this on a separate line? Move after = above.

10:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:01 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
8:29 am

Vendor - TEL - Jashwant Gantyada

This was added by Vinay to force the chamber F filling.

This was added by Vinay to force the chamber F filling.

8:27 am

Vendor - TEL - Jashwant Gantyada

It was changed by Vinay as part of the Conductivity spikes issue.

It was changed by Vinay as part of the Conductivity spikes issue.

Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

10:01 am

Vendor - TEL - Sameer Poyil

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

9:56 am

Vendor - TEL - Sameer Poyil

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

9:45 am

Vendor - TEL - Sameer Poyil

bicarbChamberLevel is a local variable and not an input

bicarbChamberLevel is a local variable and not an input

9:44 am

Vendor - TEL - Sameer Poyil

This is not required , we should design the state machine properly to handle chamber low level

This is not required , we should design the state machine properly to handle chamber low level

9:42 am

Vendor - TEL - Sameer Poyil

This is not the correct order for state machine,

This is not the correct order for state machine,

Saturday 25 Jul
10:00 pm

Sean Nash

Friday 24 Jul
4:46 pm

Sean Nash

4:37 pm

Sean Nash

Can't return in middle of function code.

Can't return in middle of function code.